Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grandorgue: init at 0.3.1-r2333 #76824

Merged
merged 2 commits into from
Mar 24, 2020
Merged

grandorgue: init at 0.3.1-r2333 #76824

merged 2 commits into from
Mar 24, 2020
+40 −0

Conversation

puzzlewolf
Copy link
Contributor

Motivation for this change

Create a package for grandorgue, a sample based pipe organ simulator.
https://sourceforge.net/projects/ourorgan/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@puzzlewolf puzzlewolf force-pushed the grandorgue/init branch 2 times, most recently from eaf2ac3 to 06f0cdd Compare January 2, 2020 16:06
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 2, 2020
symphorien
symphorien requested changes Jan 2, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
The package looks good, except for one nitpick.
I built grandOrgue with nix-review and it seems to work (makes organ-like sound), except that I get this scary warning at startup:

RtMidi error: MidiInAlsa::initialize: error creating ALSA sequencer client object.
RtMidi error: MidiOutAlsa::initialize: error creating ALSA sequencer client object.

Not sure if it is normal.
I am also intrigued at how the open file dialog works even without wrapGAppsHook, but since it works, let's not change anything in this regard.

@puzzlewolf puzzlewolf force-pushed the grandorgue/init branch 2 times, most recently from 73c0790 to 50d3cdb Compare January 3, 2020 23:26
@puzzlewolf puzzlewolf requested a review from symphorien February 6, 2020 16:39
@puzzlewolf
Copy link
Contributor Author

I found an answer to the RtMidi error at https://sourceforge.net/p/ourorgan/discussion/962124/thread/9875b915/: it should not occur if the user is a member of the audio group. However, the program works even with the error. So, I think this package should be fine :)

symphorien
symphorien approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding myself to the audio group works. Thanks!

Valodim
Valodim approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@Valodim Valodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.

not sure we can do anything about the audio group thing at package level. there is general advice to that effect already, with reasonable discoverability.

@grahamc
Copy link
Member

grahamc commented Mar 24, 2020

Hmm....

$ ./result/bin/GrandOrgue
ALSA lib pcm.c:2635:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.rear
ALSA lib pcm.c:2635:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.center_lfe
ALSA lib pcm.c:2635:(snd_pcm_open_noupdate) Unknown PCM cards.pcm.side
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm_route.c:869:(find_matching_chmap) Found no matching channel map
ALSA lib pcm.c:2556:(snd_pcm_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_pcm_pulse.so cannot be opened or _snd_pcm_pulse_open was not defined inside
ALSA lib pcm.c:2556:(snd_pcm_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_pcm_pulse.so cannot be opened or _snd_pcm_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
ALSA lib control.c:1394:(snd_ctl_open_conf) Either /nix/store/5g0ynqislkmbjr0q9zn2pp6g0qw1wg9l-alsa-plugins-1.2.1/lib/alsa-lib/libasound_module_ctl_pulse.so cannot be opened or _snd_ctl_pulse_open was not defined inside
zsh: segmentation fault (core dumped)  ./result/bin/GrandOrgue

I don't really know what to make of this.

@grahamc
Copy link
Member

grahamc commented Mar 24, 2020

The segfault was myfault. I think the only trouble is the license?

@puzzlewolf
grandorgue: init at 0.3.1-r2333

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5016a76
@puzzlewolf
Copy link
Contributor Author

Thanks for finding that license mistake 👍

@grahamc grahamc merged commit 66222ad into NixOS:master Mar 24, 2020
@grahamc
Copy link
Member

grahamc commented Mar 24, 2020

Thank you!

@puzzlewolf puzzlewolf deleted the grandorgue/init branch March 24, 2020 14:02
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc

@Valodim Valodim

@symphorien symphorien

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@puzzlewolf @grahamc @Valodim @symphorien @Janik-Haag