Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm_9: 9.0.0 -> 9.0.1 #76771

Merged
merged 2 commits into from
Jan 3, 2020
Merged

llvm_9: 9.0.0 -> 9.0.1 #76771

merged 2 commits into from
Jan 3, 2020
+14 −14

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 1, 2020

Motivation for this change

Help testing any packages depending on llvm9 in-tree appreciated,
as well as checking various platforms and patch files are still
valid and appropriate/desired.

Things done

(Testing still underway, feedback / assistance appreciated/requested :))

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer
cc @LnL7

Sorry, something went wrong.

@dtzWill dtzWill requested a review from matthewbauer as a code owner January 1, 2020 07:54
@ofborg ofborg bot requested review from lovek323 and 7c6f434c January 1, 2020 08:32
@dtzWill dtzWill force-pushed the update/llvm-9.0.1 branch from 18696c2 to dc0c28a Compare January 1, 2020 18:43
@dtzWill dtzWill changed the base branch from master to staging January 1, 2020 18:43
@ofborg ofborg bot added 6.topic: rust 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch and removed 6.topic: emacs Text editor 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 1, 2020
@dtzWill
Copy link
Member Author

dtzWill commented Jan 2, 2020

@GrahamcOfBorg build llvmPacages_9
@GrahamcOfBorg build pkgsMusl.llvmPackages_9
@GrahamcOfBorg build tests.cc-wrapper-clang-9 tests.cc-wrapper-libcxx-9
@GrahamcOfBorg build pkgsMusl.tests.cc-wrapper-clang-9 pkgsMusl.tests.cc-wrapper-libcxx-9

@dtzWill
Copy link
Member Author

dtzWill commented Jan 2, 2020

Whoops, musl cc-wrapper tests "fail" since the test attempts to use <sanitizer/asan_interface.h>. This failure is pre-existing.

LnL7
LnL7 approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and should supersede #74731

@LnL7 LnL7 merged commit dd5fd3b into NixOS:staging Jan 3, 2020
@vcunat vcunat mentioned this pull request Jan 8, 2020
Closed
10 tasks
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7

@matthewbauer matthewbauer

@lovek323 lovek323

@7c6f434c 7c6f434c

@adisbladis adisbladis

@FRidh FRidh

@infinisil infinisil

@Mic92 Mic92

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
Staging
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @LnL7 @rrbutani