Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm_9: 9.0.0 -> 9.0.1 #76771

Merged
merged 2 commits into from Jan 3, 2020
Merged

llvm_9: 9.0.0 -> 9.0.1 #76771

merged 2 commits into from Jan 3, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 1, 2020

Motivation for this change

Help testing any packages depending on llvm9 in-tree appreciated,
as well as checking various platforms and patch files are still
valid and appropriate/desired.

Things done

(Testing still underway, feedback / assistance appreciated/requested :))

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer
cc @LnL7

@ofborg ofborg bot requested review from lovek323 and 7c6f434c January 1, 2020 08:32
@FRidh FRidh added this to WIP in Staging via automation Jan 1, 2020
@dtzWill dtzWill changed the base branch from master to staging January 1, 2020 18:43
@dtzWill
Copy link
Member Author

dtzWill commented Jan 2, 2020

@GrahamcOfBorg build llvmPacages_9
@GrahamcOfBorg build pkgsMusl.llvmPackages_9
@GrahamcOfBorg build tests.cc-wrapper-clang-9 tests.cc-wrapper-libcxx-9
@GrahamcOfBorg build pkgsMusl.tests.cc-wrapper-clang-9 pkgsMusl.tests.cc-wrapper-libcxx-9

@dtzWill
Copy link
Member Author

dtzWill commented Jan 2, 2020

Whoops, musl cc-wrapper tests "fail" since the test attempts to use <sanitizer/asan_interface.h>. This failure is pre-existing.

Staging automation moved this from WIP to Ready Jan 3, 2020
LnL7
LnL7 approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and should supersede #74731

@LnL7 LnL7 merged commit dd5fd3b into NixOS:staging Jan 3, 2020
Staging automation moved this from Ready to Done Jan 3, 2020
@vcunat vcunat mentioned this pull request Jan 8, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@lovek323 lovek323 Awaiting requested review from lovek323

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@adisbladis adisbladis Awaiting requested review from adisbladis

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @LnL7