spectral: unstable 2019-08-30 -> 817, olm: cmake+clean #76767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, olm needs to be built w/cmake, missed that when picking this over. Pulling that in, let's see how that looks... |
dtzWill
force-pushed
the
update/spectral-2019-12-23
branch
from
874f0ad
to
87b617e
Compare
dtzWill
changed the title
dtzWill
changed the title
dtzWill
changed the title
|
(using github's reviewer suggestions, thank you!) |
colemickens
requested changes
Jan 13, 2020
| pname = "spectral"; | ||
| version = "unstable-2019-08-30"; | ||
| version = "817"; | ||
|
|
||
| src = fetchgit { | ||
| url = "https://gitlab.com/b0/spectral.git"; |
There was a problem hiding this comment.
update url, org is now spectral-im
|
|
||
| src = fetchgit { | ||
| url = "https://gitlab.com/b0/spectral.git"; | ||
| rev = "23237d0cb27a0b15c8e81c0e2311cc897302e6ba"; | ||
| sha256 = "11jfq97fa90r8wrahb6aasvmi7k7hr61lqgnbknsr9akn4wgvrh8"; | ||
| rev = "refs/tags/${version}"; |
There was a problem hiding this comment.
fatal: empty string is not a valid pathspec. please use . instead if you meant to match all paths
Unable to checkout refs/tags/ref/tags/817 from https://gitlab.com/spectral-im/spectral.git.
e342abb
to
cd07c91
Compare
* libsecret, now req'd * url updates
dtzWill
force-pushed
the
update/spectral-2019-12-23
branch
from
cd07c91
to
7d52215
Compare
|
On Sun, 12 Jan 2020 17:03:39 -0800, Cole Mickens ***@***.***> wrote:
colemickens requested changes on this pull request.
Might be nice to have this squashed a bit more, also.
Done!
And thanks! I've been trying my hand at this a few times and had concluded olm needed help that I wasn't prepared to give it. :)
> pname = "spectral";
- version = "unstable-2019-08-30";
+ version = "817";
src = fetchgit {
url = "https://gitlab.com/b0/spectral.git";
update url, org is now spectral-im
Included, thanks!
Updated homepage too, https://spectral.im .
>
src = fetchgit {
url = "https://gitlab.com/b0/spectral.git";
- rev = "23237d0cb27a0b15c8e81c0e2311cc897302e6ba";
- sha256 = "11jfq97fa90r8wrahb6aasvmi7k7hr61lqgnbknsr9akn4wgvrh8";
+ rev = "refs/tags/${version}";
```
fatal: empty string is not a valid pathspec. please use . instead if you meant to match all paths
Unable to checkout refs/tags/ref/tags/817 from https://gitlab.com/spectral-im/spectral.git.
```
Strange I didn't see this, dunno.
Switched to `rev=version;` hopefully that fixes things.
…
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#76767 (review) part: text/html
|
|
The rev/version/ref-tag was me applying the patch wrong. I'd left out the Anyway, it looks good to me and is a VERY welcome upgrade, I'm running it now, no issues with upgrading or havign to delete data. Thanks! :) |
|
This fixes #77034 btw. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update!
If crashes on launch, and you've previously used spectral,
I've found sometimes nuking paths like
~/.cache/ENCOM/Spectral/qmlcacheor even~/.cache/ENCOM/Spectralseems to fix things.Not sure what is going on that would cause that, just a heads-up.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @dtzWill (me 😇)