Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference_radius does not appear to take a default value C#-side #2429

Closed
eggrobin opened this issue Jan 2, 2020 · 0 comments · Fixed by #2430
Closed

reference_radius does not appear to take a default value C#-side #2429

eggrobin opened this issue Jan 2, 2020 · 0 comments · Fixed by #2430

Comments

@eggrobin
Copy link
Member

eggrobin commented Jan 2, 2020

Reported by @Damien212.
While https://github.com/mockingbirdnest/Principia/wiki/Principia-configuration-files says

  • reference_radius: an optional quantity(length).
    The reference radius ae used to make the spherical harmonics dimensionless.
    Defaults to the stock radius.

the code only does

reference_radius = node?.GetAtMostOneValue("reference_radius"),
whereas it does
reference_angle = node?.GetAtMostOneValue("reference_angle") ??
(body.initialRotation + " deg"),
when a stock-derived default is actually used.

A cursory look at blame seems to show that there never was such a default.

Note also that the documentation is somewhat out of date, in that it mentions mean_radius which is no longer configurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants