Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: remove ruleset for block #openttd-logo-ipv6 from base.css #135

Merged
merged 1 commit into from Jan 2, 2020

Conversation

auge8472
Copy link
Contributor

@auge8472 auge8472 commented Jan 2, 2020

The namely ID is not in use anymore. There is no occurence of #openttd-logo-ipv6 or openttd-logo-ipv6 in the HTML, CSS or JS sources.

glx22
glx22 previously approved these changes Jan 2, 2020
Copy link
Contributor

@glx22 glx22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes the old site had this feature, and indeed it's not used in the new version.

@LordAro
Copy link
Member

LordAro commented Jan 2, 2020

Might as well delete the file at the same time

@auge8472
Copy link
Contributor Author

auge8472 commented Jan 2, 2020

Might as well delete the file at the same time

Which file do you mean?

@LordAro
Copy link
Member

LordAro commented Jan 2, 2020

img/layout/openttd-64-ipv6.gif the one referenced in the block ;)

LordAro
LordAro previously approved these changes Jan 2, 2020
@auge8472
Copy link
Contributor Author

auge8472 commented Jan 2, 2020

img/layout/openttd-64-ipv6.gif the one referenced in the block ;)

Ah, didn't see the wood for the trees. Added a commit to remove the image.

@LordAro
Copy link
Member

LordAro commented Jan 2, 2020

Urgh, silly CI failure. Squash the commits together to get it to rerun?

…te image

The namely ID is not in use anymore.
No occurence of #openttd-logo-ipv6 or openttd-logo-ipv6 in HTML, CSS or JS.
@auge8472
Copy link
Contributor Author

auge8472 commented Jan 2, 2020

Urgh, silly CI failure. Squash the commits together to get it to rerun?

Done and "All checks have passed" :-)

@LordAro LordAro merged commit 26fbee4 into OpenTTD:master Jan 2, 2020
@auge8472 auge8472 deleted the no-ipv6 branch January 2, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants