Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apr: fix static musl build #76827

Merged
merged 1 commit into from Jan 3, 2020
Merged

apr: fix static musl build #76827

merged 1 commit into from Jan 3, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 2, 2020 •
edited

Motivation for this change

I need a static version of this library.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh FRidh requested a review from Ericson2314 January 2, 2020 16:09
@FRidh
Copy link
Member Author

FRidh commented Jan 2, 2020

Actually, cross does not function yet but static build does.

tools/gen_test_char > include/private/apr_escape_test_char.h
/nix/store/xb062l4b76zyhq6grqf4iyfdikkpg8fl-bash-4.4-p23/bin/bash: tools/gen_test_char: cannot execute binary file: Exec format error

Could try again with http://svn.apache.org/viewvc?view=revision&revision=1871998

@FRidh FRidh changed the title apr: fix cross apr: fix static musl build Jan 2, 2020
@ofborg ofborg bot requested a review from edolstra January 2, 2020 16:44
@FRidh
Copy link
Member Author

FRidh commented Jan 2, 2020

Should maybe use stdenv.hostPlatform.isMusl for now.

@FRidh FRidh changed the base branch from master to staging January 3, 2020 09:15
@FRidh FRidh merged commit 016111e into NixOS:staging Jan 3, 2020
@FRidh FRidh deleted the apr branch January 3, 2020 10:45
@FRidh FRidh mentioned this pull request Jan 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: static 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh