Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golangci-lint: 1.21.0 -> 1.22.2 #76782

Merged
merged 1 commit into from Jan 1, 2020
Merged

golangci-lint: 1.21.0 -> 1.22.2 #76782

merged 1 commit into from Jan 1, 2020

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Jan 1, 2020

Motivation for this change

This PR updates golangci-lint to its latest release. It also replaces the legacy buildGoPackage with buildGoModule.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @anpryl @manveru

@oxzi
golangci-lint: 1.21.0 -> 1.22.2
b72ac37 
Also replace legacy `buildGoPackage` with `buildGoModule`.
@ofborg ofborg bot requested review from kalbasit, anpryl and manveru January 1, 2020 13:41
@kalbasit
Copy link
Member

kalbasit commented Jan 1, 2020

@GrahamcOfBorg build golangci-lint

@kalbasit kalbasit merged commit a47ad01 into NixOS:master Jan 1, 2020
@oxzi oxzi deleted the golangci-lint-v1.22.2 branch January 2, 2020 10:22
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@geistesk @dtzWill
golangci-lint: 1.21.0 -> 1.22.2 (NixOS#76782)
6614800 
Also replace legacy `buildGoPackage` with `buildGoModule`.

(cherry picked from commit a47ad01)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@anpryl anpryl anpryl approved these changes

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @kalbasit @anpryl