Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: fix platform detection on armv5tel-linux #76812

Merged
merged 1 commit into from Mar 14, 2020
Merged

openssl: fix platform detection on armv5tel-linux #76812

merged 1 commit into from Mar 14, 2020

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Run openssh on a sheevaplug.

Without this change, openssl builds with -march=armv7-a, and openssh crashes on startup with SIGILL, Illegal instruction.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lopsided98 who pointed out the solution

lopsided98
lopsided98 approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@lopsided98 lopsided98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test it, but it looks correct to me.

@alyssais alyssais merged commit e271476 into NixOS:master Mar 14, 2020
@thefloweringash thefloweringash deleted the openssl-sheevaplug branch March 14, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopsided98 lopsided98 lopsided98 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @lopsided98 @alyssais