New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os-prober: add missing dmraid, lvm2 dependencies #76843
Conversation
Otherwise, os-prober may fail to see LVM partitions.
Thanks! For people missing context: |
If this is not done, dmraid is likely to not find OSes on RAID.
I've added dmraid. lsblk is already added by libuuid. The only commands that aren't in the program's PATH currently are log-output and anna-install. Edit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
os-prober: add missing dmraid, lvm2 dependencies
os-prober: add missing dmraid, lvm2 dependencies (cherry picked from commit edbf5d8)
Motivation for this change
Otherwise,
os-prober
may fail to see LVM and RAID partitions.Note
One might want to addThis has been done.dmraid
as well, but I don't know if this is actually necessary.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @symphorien