Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl::TimeDate: fixed TimeDate's getdate tests #76840

Closed
wants to merge 1 commit into from
Closed

perl::TimeDate: fixed TimeDate's getdate tests #76840

wants to merge 1 commit into from

Conversation

urbas
Copy link
Contributor

@urbas urbas commented Jan 2, 2020

Motivation for this change

TimeDate's getdate tests use the short notation YY as the time offset. This incorrectly uses 2070 (instead of 1970) and because of this tests fail.

Things done

This change fixes tests by using YYYY notation instead.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra

@urbas
perl::TimeDate: fixed TimeDate's getdate tests
342a990 
TimeDate's getdate tests use the short notation YY as the time offset. This incorrectly uses 2070 (instead of 1970) and because of this tests fail.

This change fixes tests by using YYYY notation instead.
@urbas
Copy link
Contributor Author

urbas commented Jan 2, 2020 •
edited

Closing in favour of PR #76810

@urbas urbas closed this Jan 2, 2020
@urbas urbas deleted the fix-perl-TimeDate-getdate-1970-offset branch December 29, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@urbas