nixos/apropos: init #76841
Closed
nixos/apropos: init #76841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
requested changes
Jan 2, 2020
| systemd.tmpfiles.rules = [ "d /var/cache/man 0755 root root -" ]; | ||
|
|
||
| system.activationScripts.apropos = '' | ||
| ${pkgs.mandb}/bin/mandb |
There was a problem hiding this comment.
Can we do this at build-time instead? Would be much cleaner. This here will run on every boot and rebuild.
There was a problem hiding this comment.
@matthewbauer are you still interested in this PR? If not I'm ok taking over this task.
There was a problem hiding this comment.
@rnhmjoj can you please have a look? It would be great to fix this old issue. Thank you.
| { | ||
|
|
||
| options.documentation.apropos = { | ||
| enable = mkOption { |
There was a problem hiding this comment.
I think this whole config can be moved to documentation.nix under the mkIf cfg.man.enable without an additional .enable option if it can be done at build time.
10 tasks
|
Closing in favor of #86489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14472
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @