Fix: check for URLs including trailing slash #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this is not really relevant in our case, LGTM rightfully indicates that these 'startswith' can still have URLs like 'https://api.github.com.fake.domain', and validate. We of course not as much use the validation to check if it really comes from github.com, merely to ensure that the next statement is valid. Nevertheless, it is a sane change to make.
LordAro
approved these changes
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this is not really relevant in our case, LGTM rightfully
indicates that these 'startswith' can still have URLs like
'https://api.github.com.fake.domain', and validate. We of course
not as much use the validation to check if it really comes from
github.com, merely to ensure that the next statement is valid.
Nevertheless, it is a sane change to make.