Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elmPackages.*: update to latest versions #76866

Merged
merged 1 commit into from Jan 6, 2020
Merged

elmPackages.*: update to latest versions #76866

merged 1 commit into from Jan 6, 2020

Conversation

andys8
Copy link
Member

@andys8 andys8 commented Jan 3, 2020

Motivation for this change

Intention is to update elm-language-server to 1.4.6. Executed update script. A bunch of node dependencies are updated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @turboMaCk @razzeee @BrianHicks

turboMaCk
turboMaCk reviewed Jan 3, 2020
View reviewed changes
Copy link
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention individual changes

pkgs/development/compilers/elm/packages/node-packages.nix
@@ -4790,57 +4889,49 @@ in
elm-test = nodeEnv.buildNodePackage {
name = "elm-test";
packageName = "elm-test";
version = "0.19.1";
version = "0.19.1-revision2";
Copy link
Member

@turboMaCk turboMaCk Jan 3, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elm-test update

pkgs/development/compilers/elm/packages/node-packages.nix
@@ -5576,64 +5666,64 @@ in
elm-upgrade = nodeEnv.buildNodePackage {
name = "elm-upgrade";
packageName = "elm-upgrade";
version = "0.19.6";
version = "0.19.7";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elm-upgrade

pkgs/development/compilers/elm/packages/node-packages.nix
@@ -5956,13 +6046,14 @@ in
elm-xref = nodeEnv.buildNodePackage {
name = "elm-xref";
packageName = "elm-xref";
version = "4.0.0";
version = "4.1.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elm-xref

pkgs/development/compilers/elm/packages/node-packages.nix
@@ -5996,10 +6091,10 @@ in
"@elm-tooling/elm-language-server" = nodeEnv.buildNodePackage {
name = "_at_elm-tooling_slash_elm-language-server";
packageName = "@elm-tooling/elm-language-server";
version = "1.4.4";
version = "1.4.6";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elm-language-server

turboMaCk
turboMaCk approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and seems to be working on NixOS 👍

@andys8
elmPackages.*: update to latest versions
d14669c 
Intention is to update elm-language-server to 1.4.6
@turboMaCk
Copy link
Member

cc @domenkozar I think this can be merged.

@domenkozar domenkozar merged commit dd9adc8 into NixOS:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turboMaCk turboMaCk turboMaCk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andys8 @turboMaCk @domenkozar