Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-flamegraph: fix runtime dep: linux-perf #76313

Merged
merged 2 commits into from Jan 2, 2020
Merged

cargo-flamegraph: fix runtime dep: linux-perf #76313

merged 2 commits into from Jan 2, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Dec 23, 2019

Motivation for this change

Fix runtime dependency to perf from linuxPackages.perf

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 31,606,936 (30 MiB) -> 234,971,768 (224 MiB)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from killercup December 23, 2019 21:39
killercup
killercup reviewed Dec 23, 2019
View reviewed changes
Copy link
Member

@killercup killercup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable but problaby won't have time to test before christmas :)

@oxalica oxalica mentioned this pull request Dec 26, 2019
Closed
@ofborg ofborg bot requested a review from killercup December 26, 2019 11:14
@Ma27 Ma27 merged commit af26f69 into NixOS:master Jan 2, 2020
@oxalica oxalica deleted the cargo-flamegraph-perf branch January 3, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@killercup killercup Awaiting requested review from killercup

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxalica @killercup @Ma27