Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gegl: remove flaky test #76846

Merged
merged 1 commit into from Jan 2, 2020
Merged

gegl: remove flaky test #76846

merged 1 commit into from Jan 2, 2020

Conversation

lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Jan 2, 2020 •
edited

Motivation for this change

Following #75773 this adds to the Debian patch with our own that removes the flaky backend-file test. This should allow for a new nixos-unstable release, since trunk-combined/tested has been failing for days due to this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @jtojnar

@lovesegfault lovesegfault changed the title gegl: remove flaky tests gegl: remove flaky test Jan 2, 2020
@ofborg ofborg bot requested a review from jtojnar January 2, 2020 23:20
@grahamc
Copy link
Member

grahamc commented Jan 2, 2020 •
edited

@GrahamcOfBorg build gegl_0_4

@lovesegfault
Copy link
Member Author 

[16 built, 473 copied (2230.8 MiB), 624.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76846
14 package built:
gegl_0_4 gimp gimp-with-plugins gimpPlugins.fourier gimpPlugins.gap gimpPlugins.gimplensfun gimpPlugins.gmic gimpPlugins.lightning gimpPlugins.lqrPlugin gimpPlugins.resynthesizer gimpPlugins.ufraw gimpPlugins.waveletSharpen gnome-photos ufraw

@grahamc grahamc merged commit 45a1974 into NixOS:master Jan 2, 2020
@lovesegfault lovesegfault deleted the gegl-no-flaky-tests branch January 2, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lovesegfault @grahamc