Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flyway: fix jarDirs option #76835

Merged
merged 1 commit into from Jan 8, 2020
Merged

flyway: fix jarDirs option #76835

merged 1 commit into from Jan 8, 2020

Conversation

jerith666
Copy link
Contributor

@jerith666 jerith666 commented Jan 2, 2020 •
edited

this is not a system property, but rather an argument to
org.flaywaydb.commandline.Main.main(). therefore, it must come after,
rather than before, the name of the main class. (otherwise it's
interpreted as an argument to the VM itself.)

flyway also expects the option and value to be separated by '=', not ' '.

follows on to #76094

Motivation for this change

was failing like this after #76094:

$ ./result/bin/flyway --help
Error: Could not find or load main class .nix.store.mviaqav8f5c80sjxw4r31sqqyn69wb0w-flyway-6.1.2.share.flyway.jars
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Rakesh4G @CMCDragonkai @teto

@jerith666
flyway: fix jarDirs option
2867d19 
this is not a system property, but rather an argument to
org.flaywaydb.commandline.Main.main().  therefore, it must come after,
rather than before, the name of the main class.  (otherwise it's
interpreted as an argument to the VM itself.)

flyway also expects the option and value to be separated by '=', not ' '.

follows on to NixOS#76094
@ofborg ofborg bot requested a review from CMCDragonkai January 2, 2020 19:09
@marsam marsam merged commit dd80b19 into NixOS:master Jan 8, 2020
@marsam
Copy link
Contributor

marsam commented Jan 8, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakesh4G Rakesh4G Rakesh4G approved these changes

@CMCDragonkai CMCDragonkai Awaiting requested review from CMCDragonkai

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jerith666 @marsam @Rakesh4G