Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Frame::unmoving in most places to denote null velocity #2424

Merged
merged 4 commits into from
Jan 1, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jan 1, 2020

Also add nonrotating for null angular velocity.

ICRS::origin,
Velocity<ICRS>()};
{Displacement<ICRS>({0 * Metre, 0 * Metre, 0 * Metre}) + ICRS::origin,
ICRS::unmoving};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's simplify that to {ICRS::origin, ICRS::unmoving}, I don't think adding 0 adds much to clarity here.

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done everywhere in this file.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Jan 1, 2020
@pleroy pleroy merged commit 6af4de8 into mockingbirdnest:master Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants