mirror-branch: Always exit with 1 on nix-instantiate error #31
Conversation
mirror-nixos-branch.pl
Outdated
| @@ -81,8 +81,9 @@ sub fetch { | |||
| exit 127; | |||
| } | |||
| if ($? > 0) { | |||
| warn("error while executing nix-instantiate ($?).\n"); | |||
| exit $?; | |||
| my $code = $? >> 8; | |||
There was a problem hiding this comment.
Looks like it's a little bit more complicated - we'll need ($? & 127) ? 127 : ($? >> 8) (parens because I don't remember operator precedence). Processes that are killed via signal leave their signal number in $? & 127, but scripts that exit leave the return code in $? >> 8 - so my suggestion is to use a synthetic 127 exit code for signal-related exits, and propagate the error code otherwise.
At this point, I think I'd suggest just simplifying this block entirely:
$! = 0; # Clear errno to avoid reporting non-fork/exec-related issues
my $d = `NIX_PATH= nix-instantiate --eval -E "builtins.compareVersions (builtins.parseDrvName \\"$curRelease\\").version (builtins.parseDrvName \\"$releaseName\\").version"`;
if ($? != 0) {
warn "Could not execute nix-instantiate: exit $?; errno $!\n";
exit 127;
}
There was a problem hiding this comment.
+1 on making the exit code static, though probably 1 is better than 127, since 127 feels very specific and somebody seeing exit 1 may correctly assume less thought went in to the code.
There was a problem hiding this comment.
Updated (including with @grahamc's comment).
samueldr
force-pushed
the
fix/2020-01-02-mirror-issue-2
branch
from
902e490
to
5591858
Compare
samueldr
changed the title
samueldr
force-pushed
the
fix/2020-01-02-mirror-issue-2
branch
from
5591858
to
5693ad5
Compare
samueldr
changed the title
Resolving the values and being fancy is harder than the actual benefits would give out. Return all the info we have, and let the pager'd person deal with the data.
samueldr
force-pushed
the
fix/2020-01-02-mirror-issue-2
branch
from
5693ad5
to
c4a61df
Compare
Resolving the values and being fancy is harder than the actual benefits
would give out.
Return all the info we have, and let the pager'd person deal with the
data.