Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.dat:added dependencies to fix compilation #76805

Merged
merged 1 commit into from Jan 3, 2020

Conversation

pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Jan 2, 2020

Motivation for this change

Fixes #76611
Thanks @lilyball for helping

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@alyssais
Copy link
Member

alyssais commented Jan 3, 2020

Can you fix the formatting in your commit message please?

@alyssais
Copy link
Member

alyssais commented Jan 3, 2020

@GrahamcOfBorg build nodePackages.dat

@alyssais alyssais merged commit a1a3745 into NixOS:master Jan 3, 2020
@pasqui23 pasqui23 deleted the dat2 branch January 4, 2020 00:25
@pasqui23 pasqui23 restored the dat2 branch June 8, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dat does not build because of broken sodium-native dependency
2 participants