Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linuxPackages.prl-tools: remove version assertion #76854

Merged

Conversation

ersinakinci
Copy link
Contributor

@ersinakinci ersinakinci commented Jan 3, 2020

Motivation for this change

This PR removes an assertion in the derivation for linuxPackages.prl-tools that disallows the derivation if the Linux kernel version is >4.15. We should remove this assertion because:

  1. New versions of Parallels Tools are compatible with kernel versions >4.15, and I'm currently in the process of updating this derivation to use the new tools.
  2. There's already a redundant assertion performing this check inside of all-packages.nix.
  3. This assertion makes it very difficult to use overlays to install an updated version of Parallels Tools in cases where the user knows that the version of the tools they want to install is compatible with their kernel version.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants