Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoneminder: Fix installation location for cgi-bin #76855

Merged
merged 1 commit into from Jan 18, 2020
Merged

zoneminder: Fix installation location for cgi-bin #76855

merged 1 commit into from Jan 18, 2020

Conversation

danielfullmer
Copy link
Contributor

Before this change, the build would duplicate the prefix in the
installation location for cgi-bin stuff. This could be found in the build log:

-- Installing: /nix/store/skg6b81hikd3fvvdf62xbkm6gsbid41a-zoneminder-1.32.3/nix/store/skg6b81hikd3fvvdf62xbkm6gsbid41a-zoneminder-1.32.3/libexec/zoneminder/cgi-bin/zms

Previewing cameras via the web interface was broken as a result of this.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peterhoeg

@danielfullmer
zoneminder: Fix installation location for cgi-bin
e4b73b6 
Before this change, the build would duplicate the prefix in the
installation location for cgi-bin stuff:
-- Installing: /nix/store/skg6b81hikd3fvvdf62xbkm6gsbid41a-zoneminder-1.32.3/nix/store/skg6b81hikd3fvvdf62xbkm6gsbid41a-zoneminder-1.32.3/libexec/zoneminder/cgi-bin/zms
@ofborg ofborg bot requested a review from peterhoeg January 3, 2020 02:29
@veprbl
Copy link
Member

veprbl commented Jan 3, 2020

We should report this upstream, they could switch from CMAKE_INSTALL_ to CMAKE_INSTALL_FULL_ as described in https://cmake.org/cmake/help/v3.16/module/GNUInstallDirs.html .

@veprbl veprbl mentioned this pull request Jan 3, 2020
Merged
10 tasks
@danielfullmer danielfullmer mentioned this pull request Jan 3, 2020
Closed
@danielfullmer
Copy link
Contributor Author

@veprbl Reported upstream: ZoneMinder/zoneminder#2792

@veprbl
Copy link
Member

veprbl commented Jan 18, 2020

@danielfullmer Sorry for delay. And thanks for reporting upstream.

@GrahamcOfBorg build zoneminder

veprbl
veprbl approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veprbl veprbl merged commit 5d1fda3 into NixOS:master Jan 18, 2020
@veprbl veprbl mentioned this pull request Feb 11, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielfullmer @veprbl