Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ec29bb50bf45
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: be3f887ac409
Choose a head ref
  • 9 commits
  • 7 files changed
  • 6 contributors

Commits on Dec 31, 2019

  1. hyperrogue: 10.5e -> 11.2d

    mehlon committed Dec 31, 2019
    Copy the full SHA
    c510bbf View commit details

Commits on Jan 1, 2020

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    328030c View commit details

Commits on Jan 3, 2020

  1. Copy the full SHA
    992245f View commit details
  2. Copy the full SHA
    d80570f View commit details
  3. Merge pull request #76852 from lovesegfault/fix-manual-boot-console

    nixos-manual: boot.extraTTYs -> console.extraTTYs
    grahamc authored Jan 3, 2020
    Copy the full SHA
    d08fc1a View commit details
  4. Merge pull request #76801 from hax404/chirp

    chirp: 20191123 -> 20191221; add support for chirp.drivers.tk8180
    fpletz authored Jan 3, 2020
    Copy the full SHA
    6a2caa5 View commit details
  5. Merge pull request #76756 from mehlon/hyperrogue

    hyperrogue: 10.5e -> 11.2d
    fpletz authored Jan 3, 2020
    Copy the full SHA
    804678f View commit details
  6. Revert "lib/types: Allow paths as submodule values"

    This reverts commit eec83d4.
    
    This broke hydra evaluation because with this commit submodule values
    are allowed to be paths, however the certmgr module uses `either
    (submodule ...) path` in its type, meaning it already used paths for
    something else which would now be interpreted as a submodule.
    infinisil committed Jan 3, 2020
    Copy the full SHA
    c7ade68 View commit details
  7. Copy the full SHA
    be3f887 View commit details
3 changes: 2 additions & 1 deletion lib/tests/modules.sh
Original file line number Diff line number Diff line change
@@ -180,7 +180,8 @@ checkConfigOutput "true" config.submodule.inner ./declare-submoduleWith-modules.
checkConfigOutput "true" config.submodule.outer ./declare-submoduleWith-modules.nix

## Paths should be allowed as values and work as expected
checkConfigOutput "true" config.submodule.enable ./declare-submoduleWith-path.nix
# Temporarily disabled until https://github.com/NixOS/nixpkgs/pull/76861
#checkConfigOutput "true" config.submodule.enable ./declare-submoduleWith-path.nix

cat <<EOF
====== module tests ======
8 changes: 3 additions & 5 deletions lib/types.nix
Original file line number Diff line number Diff line change
@@ -376,16 +376,14 @@ rec {
else unify (if shorthandOnlyDefinesConfig then { config = value; } else value);

allModules = defs: modules ++ imap1 (n: { value, file }:
if isAttrs value || isFunction value then
# Annotate the value with the location of its definition for better error messages
coerce (lib.modules.unifyModuleSyntax file "${toString file}-${toString n}") value
else value
# Annotate the value with the location of its definition for better error messages
coerce (lib.modules.unifyModuleSyntax file "${toString file}-${toString n}") value
) defs;

in
mkOptionType rec {
name = "submodule";
check = x: isAttrs x || isFunction x || path.check x;
check = x: isAttrs x || isFunction x;
merge = loc: defs:
(evalModules {
modules = allModules defs;
6 changes: 3 additions & 3 deletions nixos/doc/manual/development/option-types.xml
Original file line number Diff line number Diff line change
@@ -257,9 +257,9 @@
<listitem>
<para>
A set of sub options <replaceable>o</replaceable>.
<replaceable>o</replaceable> can be an attribute set, a function
returning an attribute set, or a path to a file containing such a value. Submodules are used in
composed types to create modular options. This is equivalent to
<replaceable>o</replaceable> can be an attribute set or a function
returning an attribute set. Submodules are used in composed types to
create modular options. This is equivalent to
<literal>types.submoduleWith { modules = toList o; shorthandOnlyDefinesConfig = true; }</literal>.
Submodules are detailed in
<xref
2 changes: 1 addition & 1 deletion nixos/modules/services/misc/nixos-manual.nix
Original file line number Diff line number Diff line change
@@ -52,7 +52,7 @@ in
};
})
(mkIf (cfg.showManual && cfgd.enable && cfgd.nixos.enable) {
boot.extraTTYs = [ "tty${toString cfg.ttyNumber}" ];
console.extraTTYs = [ "tty${toString cfg.ttyNumber}" ];

systemd.services.nixos-manual = {
description = "NixOS Manual";
2 changes: 1 addition & 1 deletion nixos/modules/services/misc/rogue.nix
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ in

config = mkIf cfg.enable {

boot.extraTTYs = [ cfg.tty ];
console.extraTTYs = [ cfg.tty ];

systemd.services.rogue =
{ description = "Rogue dungeon crawling game";
6 changes: 3 additions & 3 deletions pkgs/applications/radio/chirp/default.nix
Original file line number Diff line number Diff line change
@@ -4,15 +4,15 @@
}:
python2.pkgs.buildPythonApplication rec {
pname = "chirp-daily";
version = "20191123";
version = "20191221";

src = fetchurl {
url = "https://trac.chirp.danplanet.com/chirp_daily/daily-${version}/${pname}-${version}.tar.gz";
sha256 = "11wzk0c9fa3gp185gyd47g3sh7gfallw7qapr6qp913q2zfmif8v";
sha256 = "1f4h45cbaq3rssl95xax8gn2bm1slnsbgds479db46czgq6y1qhy";
};

propagatedBuildInputs = with python2.pkgs; [
pygtk pyserial libxml2
pygtk pyserial libxml2 future
];

meta = with stdenv.lib; {
6 changes: 3 additions & 3 deletions pkgs/games/hyperrogue/default.nix
Original file line number Diff line number Diff line change
@@ -3,13 +3,13 @@

stdenv.mkDerivation rec {
pname = "hyperrogue";
version = "10.5e";
version = "11.2d";

src = fetchFromGitHub {
owner = "zenorogue";
repo = "hyperrogue";
rev = "v${version}";
sha256 = "1sjr26if3xv8xv52app1hkxs0bbgbviagydm4mdwbxjpd6v3d1aa";
rev = stdenv.lib.strings.stringAsChars (x: if x == "." then "" else x) "v${version}";
sha256 = "0aj4xy5xjdj32l5mk8796ldh9d7h8rx35kgc1vr7acb4fhpppb0f";
};

CPPFLAGS = "-I${SDL.dev}/include/SDL";