Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fints: 2.2.0 -> 3.0.0 #76813

Merged
merged 1 commit into from Jan 6, 2020
Merged

python3Packages.fints: 2.2.0 -> 3.0.0 #76813

merged 1 commit into from Jan 6, 2020

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

Package was outdated.

Things done

Updated the package to the latest version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@d-goldin
Copy link
Contributor

d-goldin commented Jan 5, 2020

nixpkgs-review passes, lgtm.

jonringer
jonringer approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

[4 built, 9 copied (7.6 MiB), 1.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/76813
2 package built:
python37Packages.fints python38Packages.fints

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.fints python38Packages.fints

@jonringer
Copy link
Contributor

arch failure unrelated

@jonringer jonringer merged commit ab2f632 into NixOS:master Jan 6, 2020
@elohmeier elohmeier deleted the fints branch January 6, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elohmeier @d-goldin @jonringer