Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mediathekview: 13.2.1 -> 13.5.0 #73255

Merged
merged 1 commit into from Nov 20, 2019
Merged

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Nov 11, 2019

Motivation for this change

Version bump.

It now works with OpenJDK again! :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread
Copy link
Contributor Author

Moredread commented Nov 11, 2019

/nix/store/kld93k891myscac7dwhbzmk7shvp5dgl-mediathekview-13.2.1	  465469184
/nix/store/wx089v8nbw8jw4qpz2j9qx1ncbl33aql-mediathekview-13.5.0	 1171387872

I guess that is due to the switch to OpenJDK, the derivation itself is only 64M, OpenJDK is about 1.1 GB.

Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, had to set my wmname to LG3D (with wmname LG3D) then it started and I had to provide paths to vlc and ffmpeg. afterwards I could successfully watch something

@Moredread
Copy link
Contributor Author

@Lassulus Sadly this is how it worked before. I'm not sure we can set the paths from outside the application.

@Lassulus Lassulus merged commit 3945c1d into NixOS:master Nov 20, 2019
@Moredread Moredread deleted the mediathekview-13.5 branch November 20, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants