Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdns-cli: init at 0.0.5 #73313

Merged
merged 1 commit into from Nov 13, 2019
Merged

tdns-cli: init at 0.0.5 #73313

merged 1 commit into from Nov 13, 2019

Conversation

astro
Copy link
Contributor

@astro astro commented Nov 12, 2019

Motivation for this change

Another useful Rust implementation of popular DNS tools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

jonringer
jonringer approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable appears to work

[4 built, 2 copied (0.1 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73313
1 package were build:
tdns-cli

only thing is that the repo seems to be a semi-active 1-dev effort... otherwise LGTM

pkgs/tools/networking/tdns-cli/default.nix Show resolved Hide resolved
@astro
Copy link
Contributor Author

astro commented Nov 13, 2019

@jonringer Thanks for your input. I added the newline.

only thing is that the repo seems to be a semi-active 1-dev effort... otherwise LGTM

Can't argue much against that except that I see it as a frontend to the larger trust-dns effort (65 contributors, 4.5 years of development). Of course, the usual tools still work well.

rasendubi
rasendubi reviewed Nov 13, 2019
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick. Otherwise, looks good.

pkgs/tools/networking/tdns-cli/default.nix Outdated Show resolved Hide resolved
@rasendubi
Copy link
Member

@GrahamcOfBorg build tdns-cli

@rasendubi rasendubi merged commit f0f1e12 into NixOS:master Nov 13, 2019
@astro astro deleted the tdns-cli branch November 15, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi left review comments

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@astro @rasendubi @jonringer