Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.uvloop: 0.13.0 -> 0.14.0 #73247

Merged
merged 2 commits into from Nov 12, 2019
Merged

python3Packages.uvloop: 0.13.0 -> 0.14.0 #73247

merged 2 commits into from Nov 12, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 11, 2019 •
edited

Motivation for this change

noticed the python38 build was broken, this appears to fix it

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from costrouc November 11, 2019 21:24
@jonringer
Copy link
Contributor Author

bumped uvicorn because it was also broken for python38

@ofborg ofborg bot requested a review from wd15 November 11, 2019 22:40
@jonringer
Copy link
Contributor Author

failures are broken on master

[10 built (5 failed), 0.0 MiB DL]
error: build of '/nix/store/4jy9zgrp406bvr5d5rv4pq27hnf11drx-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73247
5 package failed to build:
python37Packages.fastapi python37Packages.sentry-sdk python38Packages.asyncpg python38Packages.datasette python38Packages.fastapi

16 package were build:
datasette mtprotoproxy python37Packages.asyncpg python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.uvloop python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.sanic python38Packages.starlette python38Packages.uvicorn python38Packages.uvloop sourcehut.listssrht

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build datasette mtprotoproxy python37Packages.asyncpg python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.uvloop python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.sanic python38Packages.starlette python38Packages.uvicorn python38Packages.uvloop sourcehut.listssrht

1 similar comment
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build datasette mtprotoproxy python37Packages.asyncpg python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.sanic python37Packages.starlette python37Packages.uvicorn python37Packages.uvloop python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.sanic python38Packages.starlette python38Packages.uvicorn python38Packages.uvloop sourcehut.listssrht

@jonringer
Copy link
Contributor Author

I can't see any regressions, that didn't exist before, mreging

@jonringer jonringer merged commit 98912d2 into NixOS:master Nov 12, 2019
@jonringer jonringer deleted the bump-uvloop branch February 13, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

@wd15 wd15 Awaiting requested review from wd15

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @Mic92