Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packges.sqlalchemy: disable mem tests on darwin #73248

Merged
merged 1 commit into from Nov 29, 2019
Merged

python3Packges.sqlalchemy: disable mem tests on darwin #73248

merged 1 commit into from Nov 29, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 11, 2019 •
edited

These tests fail to pickle a file locally

Motivation for this change

Trying to fix the tests, currently blocks 185 other darwin python packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
python3Packges.sqlalchemy: disable mem tests on darwin
85dfa4e 
These tests fail to pickle a file locally
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.sqlalchemy

@jonringer
Copy link
Contributor Author

seeing as darwin builds for this package are broken anyway, I will merge if this is successful

@jonringer jonringer merged commit a2e9b7b into NixOS:master Nov 29, 2019
@jonringer jonringer deleted the fix-darwin-sqlalchemy branch November 29, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @marsam