Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpdump: 2017-09-29 -> 1.6.0 #73249

Merged
merged 1 commit into from Nov 12, 2019
Merged

bgpdump: 2017-09-29 -> 1.6.0 #73249

merged 1 commit into from Nov 12, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 11, 2019

Motivation for this change

Refresh an old package
+ it was reported as problematic by Repology because of version mismatch

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nlewo

@ofborg ofborg bot requested a review from nlewo November 11, 2019 21:37
@nlewo
Copy link
Member

nlewo commented Nov 12, 2019

Thanks!

@nlewo nlewo merged commit 2767096 into NixOS:master Nov 12, 2019
@c0bw3b c0bw3b deleted the pkg/bgpdump branch November 12, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@c0bw3b @nlewo