Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guake: add missing dependency on setuptools #73250

Merged
merged 1 commit into from Nov 11, 2019
Merged

guake: add missing dependency on setuptools #73250

merged 1 commit into from Nov 11, 2019

Conversation

wamserma
Copy link
Member

Motivation for this change

guake crashed at launch due to missing dependency:

  File "/nix/store/3pwkg13xs7brvhfm3xwnkj2ygfi5lfsg-guake-3.6.3/lib/python3.7/site-packages/guake/paths.py", line 26, in <module>
    from pkg_resources import Requirement
ModuleNotFoundError: No module named 'pkg_resources'

The missing module is provided by setuptools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @msteen

@wamserma
guake: add missing dependency on setuptools
b0879a0 
python setuptools is a runtime dependency (as
from pkg_resources import Requirement
is used)
@jtojnar jtojnar merged commit 54b2edf into NixOS:master Nov 11, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Nov 11, 2019

Thanks.

wamserma pushed a commit to wamserma/nixpkgs that referenced this pull request Nov 12, 2019
@jtojnar @wamserma
Merge pull request NixOS#73250 from wamserma/guake-add-setuptools
5ab3224 
guake: add missing dependency on setuptools
@wamserma wamserma mentioned this pull request Jan 8, 2020
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/guake-failed-to-load-module-unity-gtk-module/5556/2

@wamserma wamserma deleted the guake-add-setuptools branch January 19, 2020 13:12
jtojnar added a commit that referenced this pull request Jan 19, 2020
@jtojnar
Merge pull request #73276 from wamserma/r19.09-guake-add-setuptools
d14cea0 
Merge pull request #73250 from wamserma/guake-add-setuptools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wamserma @jtojnar @nixos-discourse