New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.awkward1: init at 0.1.28 #73212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed in Nixpkgs? We have the rule to have only one version of a package in python-packages.nix
to prevent potential collisions.
@GrahamcOfBorg build python27Packages.awkward_1 python37Packages.awkward_1 python38Packages.awkward_1 @FRidh There won't be a collision, the new package provides only "import awkward1", the old one will provide "import awkward" and soon "import awkward0". |
do you mind having the directories in python-modules be named awkward0 and awkward1. Then it seems much more like two separate packages |
I don't see a reason to do that. In general, we do this directory structure for most simple multi-version packages. The awkward{0,1} business is just a quirk due to limitations of python, it will be eventually gone. |
On the other hand, a following check:
seems to indicate that if we want to maintain consistency, I should be instead renaming the attributes from |
8fa6474
to
bcbc56e
Compare
@jonringer Did as you suggested, plus the attribute rename. |
bcbc56e
to
38d7e3b
Compare
@GrahamcOfBorg build python27Packages.awkward1 python37Packages.awkward1 python38Packages.awkward1 |
@veprbl the package should be named as it is named on PyPI, in normalized form. Checking on PyOI, I see We suffix packages with e.g. |
@FRidh Thank you for clarifying. Should I then remove the commit that creates the |
Yes, please remove it. |
38d7e3b
to
17e5c46
Compare
I agree with matching the name conventions on pypi, adheres to the law of least surprise when someone is trying to use it. |
17e5c46
to
8ade12e
Compare
@GrahamcOfBorg build python27Packages.awkward1 python37Packages.awkward1 python38Packages.awkward1 |
8ade12e
to
cc23348
Compare
Motivation for this change
Implement package awkward 1.0 development branch
https://github.com/scikit-hep/awkward-1.0
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @costrouc