Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/libvirtd: install /etc/ethertypes #73211

Merged
merged 1 commit into from Nov 13, 2019
Merged

nixos/libvirtd: install /etc/ethertypes #73211

merged 1 commit into from Nov 13, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 11, 2019

Motivation for this change

Fix #58200

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @globin @peterhoeg @clefru

fpletz
fpletz approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fpletz fpletz merged commit cebc135 into NixOS:master Nov 13, 2019
@c0bw3b c0bw3b deleted the mod/libvirt branch November 13, 2019 14:22
@fpletz
Copy link
Member

fpletz commented Nov 14, 2019

Fixed in f206184.

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 14, 2019

Ah right.. Thanks @fpletz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/etc/ethertypes missing
3 participants
@c0bw3b @fpletz @eadwu