samba: 4.10.10 -> 4.11.3 #73315

risicle · 2019-11-13T00:31:33Z

Motivation for this change

~~https://nvd.nist.gov/vuln/detail/CVE-2019-10218~~
~~https://nvd.nist.gov/vuln/detail/CVE-2019-14833~~
~~https://nvd.nist.gov/vuln/detail/CVE-2019-14847~~

This was originally a security bump, but that was taken care of through a bump to 4.10.10. Still, I did the work to get 4.11 working across platforms so here it is...

In the 4.10 -> 4.11 bump, we seem to need gnutls unconditionally now, domain controller support or not. Would welcome testing on this, the nixos samba test currently hangs building the vm on my machine, old samba or new...

Things done

Notify maintainers

cc @

risicle · 2019-11-13T01:01:17Z

@GrahamcOfBorg test samba
@GrahamcOfBorg build samba samba4Full gvfs python37Packages.pysmbc

risicle · 2019-11-16T16:06:33Z

~~Hmm hold off on this one - it's got build problems on macos.~~

risicle · 2019-11-16T18:49:34Z

Fixed & tested on macos 10.13 now. Fix posted upstream: https://gitlab.com/samba-team/samba/merge_requests/912

risicle · 2019-11-23T01:08:08Z

@GrahamcOfBorg test samba
@GrahamcOfBorg build samba samba4Full gvfs python37Packages.pysmbc

bachp

Tested on my primary file server, and no issues so far.

d-goldin · 2019-12-08T18:36:58Z

I've deployed this version on my personal file-server too and so far no issues, but it's a rather simple setup.

wamserma · 2019-12-10T20:29:24Z

@risicle needs update to 4.11.3 https://www.samba.org/samba/history/samba-4.11.3.html

risicle · 2019-12-11T01:09:18Z

Done.

test is skipped automatically now

bachp · 2019-12-15T10:29:19Z

4.11.3 update is also working properly in my setup.

nh2 · 2019-12-16T03:15:38Z

cc'ing maintainer @aneeshusa

nh2 · 2019-12-16T03:17:04Z

@GrahamcOfBorg test samba

nh2 · 2019-12-16T13:40:41Z

ofborg tests all passed.

I ran nix-review.

On the commit:

$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/73315/head:refs/nix-review/1
remote: Enumerating objects: 28, done.
remote: Counting objects: 100% (28/28), done.
remote: Compressing objects: 100% (17/17), done.
remote: Total 33 (delta 18), reused 11 (delta 11), pack-reused 5
Unpacking objects: 100% (33/33), done.
From https://github.com/NixOS/nixpkgs
 + 131ff6dd9c8...a5097e915d6 master               -> refs/nix-review/0  (forced update)
 + febf38072e6...aef8f7b16b7 refs/pull/73315/head -> refs/nix-review/1  (forced update)
$ git worktree add /home/niklas/.cache/nix-review/pr-73315/nixpkgs aef8f7b16b7dd55c67bae19113dec69fbb3a4fd6
Preparing worktree (detached HEAD aef8f7b16b7)
Updating files: 100% (20435/20435), done.
HEAD is now at aef8f7b16b7 samba: remove no-longer-necessary darwin test hack
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/niklas/.cache/nix-review/pr-73315/build.nix
warning: SQLite database '/nix/var/nix/db/db.sqlite' is busy
waiting for locks or build slots...
builder for '/nix/store/blx6vq4x92ii6pghkwn4gnqiyvjcm75x-InstallNDISDK_v4_Linux.tar.gz.drv' failed with exit code 1; last 10 log lines:
  
  https://ndi.tv/sdk/
  
  Once you have downloaded the file, please use the following command and
  re-run the installation:
  
  nix-prefetch-url file://$PWD/InstallNDISDK_v4_Linux.tar.gz
  
  ***
  
cannot build derivation '/nix/store/1v59bbn3bz9y86664yp27dmp9bq66cxc-ndi-4.drv': 1 dependencies couldn't be built
waiting for locks or build slots...
waiting for locks or build slots...
error: build of '/nix/store/73in6wzsqzpsi6k4y4x2qqi3az9rnkff-duplicity-0.7.19.drv' failed: builder for '/nix/store/73in6wzsqzpsi6k4y4x2qqi3az9rnkff-duplicity-0.7.19.drv' failed with exit code 1
builder for '/nix/store/73in6wzsqzpsi6k4y4x2qqi3az9rnkff-duplicity-0.7.19.drv' failed with exit code 1; last 10 log lines:
      assert decrypted_file.read() == plaintext
  AssertionError
  
  ----------------------------------------------------------------------
  Ran 418 tests in 325.886s
  
  FAILED (failures=1, errors=10, skipped=4)
  Test failed: <unittest.runner.TextTestResult run=418 errors=10 failures=1>
  error: Test failed: <unittest.runner.TextTestResult run=418 errors=10 failures=1>
  builder for '/nix/store/73in6wzsqzpsi6k4y4x2qqi3az9rnkff-duplicity-0.7.19.drv' failed with exit code 1
waiting for locks or build slots...
waiting for locks or build slots...
waiting for locks or build slots...
error: build of '/nix/store/7brwrq6ds1y5w8x6hiczvi7xxapvvbgf-ekiga-4.0.1.drv' on 'ssh://static-haskell-nix-ci' failed: builder for '/nix/store/7brwrq6ds1y5w8x6hiczvi7xxapvvbgf-ekiga-4.0.1.drv' failed with exit code 1
builder for '/nix/store/7brwrq6ds1y5w8x6hiczvi7xxapvvbgf-ekiga-4.0.1.drv' failed with exit code 1; last 10 log lines:
  checking for gmsgfmt... /nix/store/kzz2n4csjr71ji5h0w2gvnh83d5nch3i-gettext-0.20.1/bin/msgfmt
  checking for perl... /nix/store/9a8q20iyq9si8f9sxm2afpd57gap4qlj-perl-5.30.1/bin/perl
  checking for perl >= 5.8.1... 5.30.1
  checking for XML::Parser... ok
  checking for gtk+-2.0 >= 2.20.0 adwaita-icon-theme >= 3.0.0... yes
  checking for glib-2.0 >= 2.24.0 gmodule-2.0 gobject-2.0 gthread-2.0... yes
  checking for boostlib >= 1.34... yes
  checking whether the Boost::Signals library is available... no
  configure: error: You need the boost signals library to compile Ekiga
  builder for '/nix/store/7brwrq6ds1y5w8x6hiczvi7xxapvvbgf-ekiga-4.0.1.drv' failed with exit code 1
waiting for locks or build slots...
cannot build derivation '/nix/store/5f27jb1l4k67iln1phbp6wdlczivq0iz-deja-dup-40.4.drv': 1 dependencies couldn't be built
waiting for locks or build slots...
cannot build derivation '/nix/store/rg4sf0pg6v4anji468wa7lkl9f1zs0ay-obs-ndi-4.7.1.drv': 1 dependencies couldn't be built
[591 built (3 failed), 2918 copied (16756.5 MiB), 3306.6 MiB DL]
error: unable to start any build; either increase '--max-jobs' or enable remote builds
https://github.com/NixOS/nixpkgs/pull/73315
2 package are marked as broken and were skipped:
meguca rabbitvcs

11 package failed to build:
deja-dup ekiga lutris lutris-free obs-ndi pipelight playonlinux wine wine-staging wineWowPackages.full winetricks

122 package were built:
adapta-gtk-theme almanah atom atom-beta autofs5 calls cantata celluloid chrome-gnome-shell clementine clementineUnfree curseradio deepin.dde-file-manager deepin.deepin-movie-reborn dropbox-cli elisa empathy evolution-data-server far2l feedreader ffmpeg-full folks gfbgraph gnome-online-accounts gnome-photos gnome-recipes gvfs gnome3.bijiben gnome3.cheese gnome3.evolution gnome3.file-roller gnome3.geary gnome3.gnome-applets gnome3.gnome-books gnome3.gnome-boxes gnome3.gnome-calendar gnome3.gnome-contacts gnome3.gnome-control-center gnome3.gnome-documents gnome3.gnome-initial-setup gnome3.gnome-maps gnome3.gnome-music gnome3.gnome-online-miners gnome3.gnome-panel gnome3.gnome-session gnome3.gnome-shell gnome3.gnome-software gnome3.gnome-terminal gnome3.gnome-todo gnome3.gnome-tweaks gnome3.gnome-user-share grilo-plugins gnome3.gvfs libgdata libzapojit gnome3.nautilus gnome3.nautilus-python gnome3.pomodoro shotwell gnome3.totem tracker-miners gnomeExtensions.gsconnect handbrake hydron kdeApplications.kdenetwork-filesharing kdenlive kdeApplications.kio-extras kodi kodi-wayland kodiPlain kodiPlainWayland kodiPlugins.inputstream-adaptive kodiPlugins.joystick kodiPlugins.kodi-platform kodiPlugins.pvr-hdhomerun kodiPlugins.pvr-hts kodiPlugins.pvr-iptvsimple kodiPlugins.steam-controller kodiPlugins.vfs-libarchive kodiPlugins.vfs-sftp libsForQt5.phonon-backend-vlc vlc liquidsoap megaglest minitube mpc-qt mpd mpv mpv-with-scripts netease-cloud-music obs-linuxbrowser obs-studio obs-wlrobs olive-editor pantheon.elementary-calendar pantheon.elementary-greeter pantheon.elementary-session-settings pantheon.extra-elementary-contracts pantheon.wingpanel-indicator-datetime pantheon.wingpanel-with-indicators plex-media-player pympress python27Packages.pydub python27Packages.pysmbc python27Packages.python-vlc python37Packages.mpv python37Packages.pydub python37Packages.pysmbc python37Packages.python-vlc python38Packages.mpv python38Packages.pydub python38Packages.pysmbc python38Packages.python-vlc samba sambaFull smbnetfs soundkonverter sssd strawberry system-config-printer tribler xmonad_log_applet

[0.0 MiB DL]
error: build log of '/nix/store/5f27jb1l4k67iln1phbp6wdlczivq0iz-deja-dup-40.4.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/ppp480j7kw0saaz0ibzb2p4v6nl4ivys-lutris.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/nszla9730bsypyg3z6q1id3pglj94b3g-lutris.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/rg4sf0pg6v4anji468wa7lkl9f1zs0ay-obs-ndi-4.7.1.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/igq1ifv6yilvbfzhchczj78vh5sn7qd5-pipelight-0.2.8.2.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/fagrbkk3ngpnd4f3vmcysj82ss62rksb-playonlinux-4.3.4.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/dm4jdklba2psamvrvvwpbywbl6xnhznv-wine-4.0.2.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/szrr7gmwksp1rzjif40n72wh8yy9wn5g-wine-4.17-staging.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/lkjkp8gp2ilpvjzim2gs710qav1f8jjh-wine-wow-4.0.2.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/hlvjzjvm6hdhhv7ykxyisrnapszq9dj5-winetricks-20190912.drv' is not available
$ nix-shell /home/niklas/.cache/nix-review/pr-73315/shell.nix
these paths will be fetched (0.42 MiB download, 2.39 MiB unpacked):
  /nix/store/2m7dbdkkhjdp9faxllbxhz2gxycm1dav-bash-interactive-4.4-p23-doc
  /nix/store/xd6hnanhd3zd1pbwn28nbn8alk4268g2-bash-interactive-4.4-p23-info
  /nix/store/xw57zx1yyz7kjqwlndq0mn6h2vzlm8v9-bash-interactive-4.4-p23-dev
copying path '/nix/store/2m7dbdkkhjdp9faxllbxhz2gxycm1dav-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/xd6hnanhd3zd1pbwn28nbn8alk4268g2-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/xw57zx1yyz7kjqwlndq0mn6h2vzlm8v9-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

[nix-shell:~/.cache/nix-review/pr-73315]$

Rebased on master:

$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/73315/head:refs/nix-review/1
remote: Enumerating objects: 14, done.
remote: Counting objects: 100% (14/14), done.
remote: Compressing objects: 100% (8/8), done.
remote: Total 14 (delta 7), reused 7 (delta 5), pack-reused 0
Unpacking objects: 100% (14/14), done.
From https://github.com/NixOS/nixpkgs
   a5097e915d6..303c94493c3  master     -> refs/nix-review/0
$ git worktree add /home/niklas/.cache/nix-review/pr-73315-1/nixpkgs 303c94493c36406159c033aa9100e4aac534e366
Preparing worktree (detached HEAD 303c94493c3)
Updating files: 100% (20463/20463), done.
HEAD is now at 303c94493c3 Merge pull request #75588 from gege251/darwin-amazon-ecs-cli
$ git merge --no-commit aef8f7b16b7dd55c67bae19113dec69fbb3a4fd6
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 4 --option build-use-sandbox true -f /home/niklas/.cache/nix-review/pr-73315-1/build.nix
warning: SQLite database '/nix/var/nix/db/db.sqlite' is busy
error: build of '/nix/store/9gnbq9w9shs1q22prwwn6pz2aq9px1fk-pangox-compat-0.0.2.drv' failed: builder for '/nix/store/9gnbq9w9shs1q22prwwn6pz2aq9px1fk-pangox-compat-0.0.2.drv' failed with exit code 2
builder for '/nix/store/9gnbq9w9shs1q22prwwn6pz2aq9px1fk-pangox-compat-0.0.2.drv' failed with exit code 1; last 10 log lines:
  pangox.c:1381:3: warning: 'pango_map_get_engine' is deprecated [-Wdeprecated-declarations]
     return (PangoEngineShape *)pango_map_get_engine (shape_map, script);
     ^~~~~~
  In file included from pangox-private.h:26,
                   from pangox.c:30:
  /nix/store/6n6icd9pmmzdl7k39mdksv3k8y2z1bfn-pango-1.44.7-dev/include/pango-1.0/pango/pango-modules.h:63:16: note: declared here
   PangoEngine *  pango_map_get_engine  (PangoMap            *map,
                  ^~~~~~~~~~~~~~~~~~~~
  make: *** [Makefile:428: libpangox_1_0_la-pangox.lo] Error 1
  builder for '/nix/store/9gnbq9w9shs1q22prwwn6pz2aq9px1fk-pangox-compat-0.0.2.drv' failed with exit code 2
builder for '/nix/store/13qb5yp1v9r4cpabhxipqqxfkl51bqsj-InstallNDISDK_v4_Linux.tar.gz.drv' failed with exit code 1; last 10 log lines:
  
  https://ndi.tv/sdk/
  
  Once you have downloaded the file, please use the following command and
  re-run the installation:
  
  nix-prefetch-url file://$PWD/InstallNDISDK_v4_Linux.tar.gz
  
  ***
  
cannot build derivation '/nix/store/0b072a09k16rgz7kaipppp626dvh1r3k-ndi-4.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qiphmrqqjbprg9fr2k1crf368pksl10y-lutris-usr-target.drv': 1 dependencies couldn't be built
waiting for locks or build slots...
waiting for locks or build slots...
waiting for locks or build slots...
error: build of '/nix/store/5wlsr6fq5m5s6wzdhvxqa9ix50r308wg-ekiga-4.0.1.drv' failed: builder for '/nix/store/5wlsr6fq5m5s6wzdhvxqa9ix50r308wg-ekiga-4.0.1.drv' failed with exit code 1
builder for '/nix/store/5wlsr6fq5m5s6wzdhvxqa9ix50r308wg-ekiga-4.0.1.drv' failed with exit code 1; last 10 log lines:
  checking for gmsgfmt... /nix/store/q94jgppkjmqs1djawx4c28ywdars5qcn-gettext-0.20.1/bin/msgfmt
  checking for perl... /nix/store/ihgwxaqh6c80kh581vhw8lkgljd4mdnv-perl-5.30.1/bin/perl
  checking for perl >= 5.8.1... 5.30.1
  checking for XML::Parser... ok
  checking for gtk+-2.0 >= 2.20.0 adwaita-icon-theme >= 3.0.0... yes
  checking for glib-2.0 >= 2.24.0 gmodule-2.0 gobject-2.0 gthread-2.0... yes
  checking for boostlib >= 1.34... yes
  checking whether the Boost::Signals library is available... no
  configure: error: You need the boost signals library to compile Ekiga
  builder for '/nix/store/5wlsr6fq5m5s6wzdhvxqa9ix50r308wg-ekiga-4.0.1.drv' failed with exit code 1
error: build of '/nix/store/dbcjp9ppmsdv18dq256vb2fsicgl0zfn-handbrake-1.2.2.drv' on 'ssh://static-haskell-nix-ci' failed: builder for '/nix/store/dbcjp9ppmsdv18dq256vb2fsicgl0zfn-handbrake-1.2.2.drv' failed with exit code 2
builder for '/nix/store/dbcjp9ppmsdv18dq256vb2fsicgl0zfn-handbrake-1.2.2.drv' failed with exit code 1; last 10 log lines:
   hb_font_t *           pango_font_get_hb_font       (PangoFont        *font);
   ^~~~~~~~~
  make[3]: *** [Makefile:662: callbacks.o] Error 1
  make[3]: Leaving directory '/build/HandBrake-1.2.2/build/gtk/src'
  make[2]: *** [Makefile:451: all-recursive] Error 1
  make[2]: Leaving directory '/build/HandBrake-1.2.2/build/gtk'
  make[1]: *** [Makefile:383: all] Error 2
  make[1]: Leaving directory '/build/HandBrake-1.2.2/build/gtk'
  make: *** [../gtk/module.rules:30: gtk.build] Error 2
  builder for '/nix/store/dbcjp9ppmsdv18dq256vb2fsicgl0zfn-handbrake-1.2.2.drv' failed with exit code 2
waiting for locks or build slots...
waiting for locks or build slots...
cannot build derivation '/nix/store/mpvnd5g64c858kvjh10s5zxm3w4ba4gh-obs-ndi-4.7.1.drv': 1 dependencies couldn't be built
[176 built (4 failed), 2457 copied (14912.8 MiB), 2254.9 MiB DL]
error: unable to start any build; either increase '--max-jobs' or enable remote builds
https://github.com/NixOS/nixpkgs/pull/73315
2 package are marked as broken and were skipped:
meguca rabbitvcs

11 package failed to build:
ekiga handbrake lutris lutris-free obs-ndi pipelight playonlinux wine wine-staging wineWowPackages.full winetricks

122 package were built:
adapta-gtk-theme almanah atom atom-beta autofs5 calls cantata celluloid chrome-gnome-shell clementine clementineUnfree curseradio deepin.dde-file-manager deepin.deepin-movie-reborn deja-dup dropbox-cli elisa empathy evolution-data-server far2l feedreader ffmpeg-full folks gfbgraph gnome-online-accounts gnome-photos gnome-recipes gvfs gnome3.bijiben gnome3.cheese gnome3.evolution gnome3.file-roller gnome3.geary gnome3.gnome-applets gnome3.gnome-books gnome3.gnome-boxes gnome3.gnome-calendar gnome3.gnome-contacts gnome3.gnome-control-center gnome3.gnome-documents gnome3.gnome-initial-setup gnome3.gnome-maps gnome3.gnome-music gnome3.gnome-online-miners gnome3.gnome-panel gnome3.gnome-session gnome3.gnome-shell gnome3.gnome-software gnome3.gnome-terminal gnome3.gnome-todo gnome3.gnome-tweaks gnome3.gnome-user-share grilo-plugins gnome3.gvfs libgdata libzapojit gnome3.nautilus gnome3.nautilus-python gnome3.pomodoro shotwell gnome3.totem tracker-miners gnomeExtensions.gsconnect hydron kdeApplications.kdenetwork-filesharing kdenlive kdeApplications.kio-extras kodi kodi-wayland kodiPlain kodiPlainWayland kodiPlugins.inputstream-adaptive kodiPlugins.joystick kodiPlugins.kodi-platform kodiPlugins.pvr-hdhomerun kodiPlugins.pvr-hts kodiPlugins.pvr-iptvsimple kodiPlugins.steam-controller kodiPlugins.vfs-libarchive kodiPlugins.vfs-sftp libsForQt5.phonon-backend-vlc vlc liquidsoap megaglest minitube mpc-qt mpd mpv mpv-with-scripts netease-cloud-music obs-linuxbrowser obs-studio obs-wlrobs olive-editor pantheon.elementary-calendar pantheon.elementary-greeter pantheon.elementary-session-settings pantheon.extra-elementary-contracts pantheon.wingpanel-indicator-datetime pantheon.wingpanel-with-indicators plex-media-player pympress python27Packages.pydub python27Packages.pysmbc python27Packages.python-vlc python37Packages.mpv python37Packages.pydub python37Packages.pysmbc python37Packages.python-vlc python38Packages.mpv python38Packages.pydub python38Packages.pysmbc python38Packages.python-vlc samba sambaFull smbnetfs soundkonverter sssd strawberry system-config-printer tribler xmonad_log_applet

[0.0/0.0 MiB DL]
error: build log of '/nix/store/a51c6xih1y3rk7g4f672myj55q91gnbi-lutris.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/vbpd5xqhssmsflii7ii27k43kbxrq89a-lutris.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/mpvnd5g64c858kvjh10s5zxm3w4ba4gh-obs-ndi-4.7.1.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/9qgs627qaa2hlsymymhxzzhym55j48by-pipelight-0.2.8.2.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/0lik1cjamqn6lqggf8himmbxzicp3kwp-playonlinux-4.3.4.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/l5f9pd0nbmaha65wvg6nx9nyxhd9lj7d-wine-4.0.2.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/jrqncj4ami35n5rq22n4ajqwml8vwxd0-wine-4.17-staging.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/dp3q96j1c2scw4jd85kxvnb4m9v0ig4n-wine-wow-4.0.2.drv' is not available
[0.0 MiB DL]
error: build log of '/nix/store/hippmwq5xclb3f8s42c43v26wd44pz2i-winetricks-20190912.drv' is not available
$ nix-shell /home/niklas/.cache/nix-review/pr-73315-1/shell.nix
these paths will be fetched (0.42 MiB download, 2.39 MiB unpacked):
  /nix/store/4i9hpc99kiggxpmir0wym65grxmi5cjh-bash-interactive-4.4-p23-dev
  /nix/store/npsm8i26534is2x1div4pv7qn776rz7g-bash-interactive-4.4-p23-info
  /nix/store/z8r3v7h591qg4wlaag8m2xx1g7q5i6la-bash-interactive-4.4-p23-doc
copying path '/nix/store/z8r3v7h591qg4wlaag8m2xx1g7q5i6la-bash-interactive-4.4-p23-doc' from 'https://cache.nixos.org'...
copying path '/nix/store/npsm8i26534is2x1div4pv7qn776rz7g-bash-interactive-4.4-p23-info' from 'https://cache.nixos.org'...
copying path '/nix/store/4i9hpc99kiggxpmir0wym65grxmi5cjh-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

[nix-shell:~/.cache/nix-review/pr-73315-1]$

None of the failing packages look samba related.

So LGTM, but @risicle you should probably switch this to staging given that it mass-rebuilds a lot of stuff.

nh2 · 2020-01-10T13:44:23Z

I'll take the liberty to re-target it to staging.

nh2 · 2020-01-10T13:45:21Z

@GrahamcOfBorg test samba
@GrahamcOfBorg build samba samba4Full gvfs python37Packages.pysmbc
@GrahamcOfBorg test samba

nh2 · 2020-01-11T03:53:46Z

staging build fails on dependency libselinux-2.9

nh2 · 2020-01-27T12:41:34Z

Included in / superseeded by merged #78574.

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Nov 13, 2019

veprbl added the 1.severity: security label Nov 13, 2019

risicle mentioned this pull request Nov 13, 2019

[r19.09] samba: 4.10.8 -> 4.10.10, addressing CVE-2019-10218, CVE-2019-14833 & CVE-2019-14847 #73366

Closed

10 tasks

risicle force-pushed the ris-samba-4.11.2 branch from 32c1957 to 714fde2 Compare November 16, 2019 18:48

risicle force-pushed the ris-samba-4.11.2 branch 2 times, most recently from 38041a1 to 1fda69c Compare November 23, 2019 01:05

risicle changed the title ~~samba: 4.10.8 -> 4.11.2, addressing CVE-2019-10218, CVE-2019-14833 & CVE-2019-14847~~ samba: 4.10.10 -> 4.11.2 Nov 23, 2019

bachp approved these changes Dec 8, 2019

View reviewed changes

risicle force-pushed the ris-samba-4.11.2 branch from 1fda69c to df2f19b Compare December 11, 2019 01:08

risicle added 2 commits December 11, 2019 19:16

samba: 4.10.11 -> 4.11.3

9ad83d4

samba: remove no-longer-necessary darwin test hack

aef8f7b

test is skipped automatically now

risicle force-pushed the ris-samba-4.11.2 branch from df2f19b to aef8f7b Compare December 11, 2019 19:17

nh2 changed the title ~~samba: 4.10.10 -> 4.11.2~~ samba: 4.10.10 -> 4.11.3 Dec 16, 2019

nh2 removed the 1.severity: security label Dec 16, 2019

nh2 approved these changes Dec 16, 2019

View reviewed changes

bachp approved these changes Jan 8, 2020

View reviewed changes

nh2 changed the base branch from master to staging January 10, 2020 13:44

nh2 self-assigned this Jan 10, 2020

bachp mentioned this pull request Jan 26, 2020

samba: 4.10.11 -> 4.11.5 #78574

Merged

10 tasks

nh2 added the 1.severity: security label Jan 27, 2020

nh2 closed this Jan 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samba: 4.10.10 -> 4.11.3 #73315

samba: 4.10.10 -> 4.11.3 #73315

risicle commented Nov 13, 2019 •

edited

risicle commented Nov 13, 2019

risicle commented Nov 16, 2019 •

edited

risicle commented Nov 16, 2019

risicle commented Nov 23, 2019

bachp left a comment •

edited

d-goldin commented Dec 8, 2019

wamserma commented Dec 10, 2019

risicle commented Dec 11, 2019

bachp commented Dec 15, 2019

nh2 commented Dec 16, 2019

nh2 commented Dec 16, 2019

nh2 commented Dec 16, 2019

nh2 commented Jan 10, 2020

nh2 commented Jan 10, 2020

nh2 commented Jan 11, 2020

nh2 commented Jan 27, 2020

samba: 4.10.10 -> 4.11.3 #73315

samba: 4.10.10 -> 4.11.3 #73315

Conversation

risicle commented Nov 13, 2019 • edited

Motivation for this change

Things done

Notify maintainers

risicle commented Nov 13, 2019

risicle commented Nov 16, 2019 • edited

risicle commented Nov 16, 2019

risicle commented Nov 23, 2019

bachp left a comment • edited

Choose a reason for hiding this comment

d-goldin commented Dec 8, 2019

wamserma commented Dec 10, 2019

risicle commented Dec 11, 2019

bachp commented Dec 15, 2019

nh2 commented Dec 16, 2019

nh2 commented Dec 16, 2019

nh2 commented Dec 16, 2019

nh2 commented Jan 10, 2020

nh2 commented Jan 10, 2020

nh2 commented Jan 11, 2020

nh2 commented Jan 27, 2020

risicle commented Nov 13, 2019 •

edited

risicle commented Nov 16, 2019 •

edited

bachp left a comment •

edited