Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpxsee: 7.16 -> 7.17 #73197

Merged
merged 1 commit into from Nov 16, 2019
Merged

gpxsee: 7.16 -> 7.17 #73197

merged 1 commit into from Nov 16, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Nov 11, 2019

Motivation for this change

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @womfoo

@ofborg ofborg bot requested a review from womfoo November 11, 2019 07:29
@sikmir
Copy link
Member Author

sikmir commented Nov 11, 2019

@womfoo, @jonringer I would like to enable build on darwin, but there is one install error at the end:

$ nix-build -A gpxsee
...
installing
install flags: SHELL=/nix/store/5ys0r8acw7kx5daia5nshycrw0wwnn1g-bash-4.4-p23/bin/bash install
xcrun: error: missing DEVELOPER_DIR path:
...

Just in case, any ideas on how to resolve it? I've tried different suggestions about DEVELOPER_DIR with no luck so far.

@bjornfor bjornfor merged commit 1421eee into NixOS:master Nov 16, 2019
@jonringer
Copy link
Contributor

I unfortunately don't know :(

@sikmir sikmir deleted the gpxsee branch November 17, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@womfoo womfoo Awaiting requested review from womfoo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @jonringer @bjornfor