New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpdk: build with meson, odp-dpdk: -> 1.22.0.0 #73186
Conversation
"-Denable_kmods=${if kernel != null then "true" else "false"}" | ||
] | ||
++ lib.optional (shared == false) [ "-Ddefault_library=static" ] | ||
++ lib.optional stdenv.isx86_64 "-Dmachine=nehalem" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it is possible to make this configurable for the package? i might want to have avx512 support and maybe override the package then... (so that we can get -march=native -mtune=native -maxv512)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I we could make what's passed at -Dmachine=
configurable, or users can always override mesonFlags
. What did you mean?
I would advice against native
though, for reproducibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You already approved means you'll do a followup PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
erm. i have a cusom dpdk package with full optimizations ( -mavx512f etc ). so actually i don't care about this package that much anymore. dpdk and it's perfomance rely heavily on compiler optimizations and architecture specific settings. so unless, one day, they have a fat binary like in hyperscan, i have to use a local package then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay :-)
@GrahamcOfBorg build dpdk odp-dpdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than this, the expression looks looks good at a glance.
Build with dpdk 18.11.5 instead of 17.11.9
This converts the dpdk build to meson, and bumps odp-dpdk to the latest version.
Due to some cleanups, we can now build dynamically, and also build on aarch64-linux, which is a very interesting target for dpdk :-)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)