Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpdk: build with meson, odp-dpdk: -> 1.22.0.0 #73186

Merged
merged 2 commits into from Nov 24, 2019
Merged

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 10, 2019

This converts the dpdk build to meson, and bumps odp-dpdk to the latest version.

Due to some cleanups, we can now build dynamically, and also build on aarch64-linux, which is a very interesting target for dpdk :-)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

"-Denable_kmods=${if kernel != null then "true" else "false"}"
]
++ lib.optional (shared == false) [ "-Ddefault_library=static" ]
++ lib.optional stdenv.isx86_64 "-Dmachine=nehalem"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think it is possible to make this configurable for the package? i might want to have avx512 support and maybe override the package then... (so that we can get -march=native -mtune=native -maxv512)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I we could make what's passed at -Dmachine= configurable, or users can always override mesonFlags. What did you mean?

I would advice against native though, for reproducibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already approved means you'll do a followup PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erm. i have a cusom dpdk package with full optimizations ( -mavx512f etc ). so actually i don't care about this package that much anymore. dpdk and it's perfomance rely heavily on compiler optimizations and architecture specific settings. so unless, one day, they have a fat binary like in hyperscan, i have to use a local package then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay :-)

pkgs/os-specific/linux/dpdk/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/dpdk/default.nix Outdated Show resolved Hide resolved
@flokli
Copy link
Contributor Author

flokli commented Nov 15, 2019

@GrahamcOfBorg build dpdk odp-dpdk

@ofborg ofborg bot requested a review from magenbluten November 15, 2019 14:33
@flokli flokli requested a review from jtojnar November 15, 2019 16:10
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this, the expression looks looks good at a glance.

pkgs/os-specific/linux/dpdk/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/dpdk/default.nix Outdated Show resolved Hide resolved
@flokli
Copy link
Contributor Author

flokli commented Nov 17, 2019

rebased on top of #73555 (cc @risicle)

@flokli flokli merged commit 1ced142 into NixOS:master Nov 24, 2019
@flokli flokli deleted the bump-dpdk branch November 24, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants