zpool-trim.service: Enable choosing pools #73322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, is this the sort of thing that's acceptable to backport to 19.09? |
|
Do you still need this option after #81610 has been added? |
|
This is still useful to prevent the errors from happening in the first place. This can also speed up the loop if you only want specific pools trimmed. |
|
It no longer should break on errors. I also don't see how speed is a concern when this loop runs only once a week. |
|
It was more about efficiency and lack of polluting logs with error messages to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unlike
services.zfs.autoScrub, you can't choose which pools to affect withservices.zfs.trim. This was an issue for me when my HDD pool caused any userlandzfs/zpoolprocesses to hang for some reason while it tried to trim the HDD pool (and failed after 5min, probably from systemd killing it, which then allowed the userland processes to continue). When I used this patch to only trim my SSD pool, everything went fine.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @Mic92, is this a good enough reason to go back to
scriptfromExecStart? I could do it with a one-liner, but it just seemed very messy.