Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #73250 from wamserma/guake-add-setuptools #73276

Merged
merged 1 commit into from Jan 19, 2020
Merged

Merge pull request #73250 from wamserma/guake-add-setuptools #73276

merged 1 commit into from Jan 19, 2020

Conversation

wamserma
Copy link
Member

@wamserma wamserma commented Nov 12, 2019 •
edited

guake: add missing dependency on setuptools

Motivation for this change

backport of #73250

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jtojnar @wamserma
Merge pull request NixOS#73250 from wamserma/guake-add-setuptools
5ab3224 
guake: add missing dependency on setuptools
@wamserma wamserma changed the base branch from nixos-19.09 to release-19.09 January 8, 2020 09:37
@erictapen erictapen mentioned this pull request Jan 9, 2020
Merged
10 tasks
@jtojnar jtojnar merged commit d14cea0 into NixOS:release-19.09 Jan 19, 2020
@wamserma wamserma deleted the r19.09-guake-add-setuptools branch January 19, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wamserma @jtojnar