Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ghc-paths-nix-ghcjs.patch #73170

Merged
merged 1 commit into from Nov 11, 2019
Merged

fix ghc-paths-nix-ghcjs.patch #73170

merged 1 commit into from Nov 11, 2019

Conversation

MarcFontaine
Copy link
Contributor

@MarcFontaine MarcFontaine commented Nov 10, 2019 •
edited

Motivation for this change

This patch is used in pkgs/development/haskell-modules/configuration-ghcjs.nix
to fix the ghc-path package for use with ghcjs.
The ghc-paths package has been updated in a way that the existing patch can no longer
be applied.
This PR fixes the patch-file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @obadz

@MarcFontaine
ghcjs : fix the patch for ghc-paths-package
8142cad 
This patch is used in pkgs/development/haskell-modules/configuration-ghcjs.nix
to fix the ghc-path package for use with ghcjs.
The ghc-paths package has been updated in a way that the existing patch can no longer
be applied.
@MarcFontaine MarcFontaine marked this pull request as ready for review November 10, 2019 18:23
@cdepillabout
Copy link
Member

@MarcFontaine thanks for this PR.

I'm not super familiar with the ghcjs infrastructure in nixpkgs. How do you recommend I test this?

Is doing something like nix-build -A haskell.packages.ghcjs.ghc-paths sufficient? I just did this on my machine, and I've confirmed that with the current master, ghc-paths can't build because the patch doesn't apply, but with this PR, it does build.

@GrahamcOfBorg build haskell.packages.ghcjs.ghc-paths

@MarcFontaine
Copy link
Contributor Author

@cdepillabout thanks for looking at the PR.
Yes, nix-build -A haskell.packages.ghcjs.ghc-paths was exactly my test for this patch.
(should have added it to the description..)

I'm not very familiar the ghcjs either. I was trying to build a small ghcjs demo app which broke at the ghc-paths library and with this PR I got the build running past that point and build another thirty or so packages (before failing at something else, where I gave up).
This is the relevant PR that broke the patch and which this PR is based on:
simonmar/ghc-paths@6497ecc

@cdepillabout
Copy link
Member

Okay, this looks good to me, and it appears to have fixed something that was previously broken.

I'll go ahead and merge it.

Thanks!

@cdepillabout cdepillabout merged commit 2df923e into NixOS:master Nov 11, 2019
@MarcFontaine MarcFontaine deleted the mafo/ghcjs branch November 11, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcFontaine @cdepillabout