Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kdeFrameworks: 5.62 -> 5.64; kdeApplications: 19.08.2 -> 19.08.3 #73304

Merged
merged 4 commits into from Dec 2, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Nov 12, 2019

Motivation for this change

Update KDE Framework and applications
#71232 was already updating the framework but is blocked by the new Plasma update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nyanloutre nyanloutre changed the base branch from master to staging November 14, 2019 15:34
@nyanloutre nyanloutre marked this pull request as ready for review November 14, 2019 19:51
@nyanloutre
Copy link
Member Author

ran nixosTests.plasma5 successfully

@nyanloutre
Copy link
Member Author

@GrahamcOfBorg test plasma5

@FRidh FRidh added this to Needs review in Staging Nov 19, 2019
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Staging automation moved this from Needs review to Ready Dec 2, 2019
@ttuegel ttuegel merged commit a33c5c9 into NixOS:staging Dec 2, 2019
Staging automation moved this from Ready to Done Dec 2, 2019
@nyanloutre nyanloutre deleted the kdeapps_19_08_3 branch December 2, 2019 14:44
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 3, 2019
kdeFrameworks: 5.62 -> 5.64; kdeApplications: 19.08.2 -> 19.08.3
(cherry picked from commit a33c5c9)
@nyanloutre nyanloutre mentioned this pull request Dec 10, 2019
10 tasks
@FRidh
Copy link
Member

FRidh commented Dec 11, 2019

Could you have a look at the failing akonadi build on staging-next?
https://hydra.nixos.org/build/108066998
If you know of a fix, please open a PR to staging-next

@nyanloutre
Copy link
Member Author

Opened #75533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants