Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinGW: Enable C++ threads with mcfgthreads for 19.09 #73265

Merged
merged 10 commits into from Nov 12, 2019
Merged

MinGW: Enable C++ threads with mcfgthreads for 19.09 #73265

merged 10 commits into from Nov 12, 2019

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #73195

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ericson2314
fetchurl: Eliminate pointless cross differences
38ebb8f
@Ericson2314
lib: Switch to w64 vendor for MinGW
9171853 
It is needed for the `-municode` flag, supposedly.
@Ericson2314
windows top-level: Clean up with makeScope
0a63190
@Ericson2314
mcfgthreads: Init from git
06c5e81
@Ericson2314
mingw-w64 libc: Multiple outputs and parallel builds
999ef20 
Also deduplicate more of the GCC derivations.
@Ericson2314
gcc: Build MinGW stage two with threading library
04cb05d 
Currently this is set up to be mcfgthreads, but it could be something
else instead.
@Ericson2314
pcre: Skip winpthread dep
89ec69e 
Seems to build just fine without it, maybe it was just using C++ threads
which mcfgthread provides?
@Ericson2314
boehm-gc: Fix build on MinGW with mcfgthreads
e00237e 
CC @lhmouse
@Ericson2314
openssl: Switch deafult for MinGW
dec8d2c 
Working around broken build for now.
@Ericson2314
nghttp2: Fix MinGW build by skipping some optional deps
63eac67 
I think those deps could be made to build, but I didn't want to get
bogged down investigating further. "Use flags" are always a good thing,
so this is fine for now.
@Ericson2314 Ericson2314 mentioned this pull request Nov 12, 2019
Closed
@Ericson2314 Ericson2314 merged commit ef8c34c into NixOS:release-19.09 Nov 12, 2019
@bgamari bgamari mentioned this pull request Nov 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer matthewbauer is a code owner

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ericson2314