Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update contributors documentation for nix-review #73217

Merged
merged 3 commits into from Nov 12, 2019
Merged

update contributors documentation for nix-review #73217

merged 3 commits into from Nov 12, 2019

Conversation

DavHau
Copy link
Member

@DavHau DavHau commented Nov 11, 2019

Useful for newcomers who want to do their review after committing and then stumbling across the PR checklist.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@DavHau
update contributors documentation for nix-review
b2879c4 
Useful for newcomers who want to do their review after committing and then stumbling across the PR checklist.
davidak
davidak approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavHau @markuskowa
Apply suggestions from code review
a26ec49 
Co-Authored-By: markuskowa <markus.kowalewski@gmail.com>
@DavHau
replace nix-shell with nix run
e4c26a9 
suggestion from review
@markuskowa markuskowa merged commit 331f45f into NixOS:master Nov 12, 2019
@FRidh
Copy link
Member

FRidh commented Nov 13, 2019

Please check it builds before submitting. One new tag was added without closing it and another closing one was removed. 7805d43

@markuskowa
Copy link
Member

@FRidh Oops, sorry, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@davidak davidak davidak approved these changes

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DavHau @FRidh @markuskowa @davidak @Mic92