Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circus: fix incompatible dependency of python-circus #73199

Merged
merged 3 commits into from Nov 11, 2019
Merged

circus: fix incompatible dependency of python-circus #73199

merged 3 commits into from Nov 11, 2019

Conversation

tekeri
Copy link
Contributor

@tekeri tekeri commented Nov 11, 2019

Motivation for this change

Fix runtime failure

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh @volth @etu @xeji

@FRidh
Copy link
Member

FRidh commented Nov 11, 2019

In the Python packages set only one version of a package at the time is allowed.

@tekeri
Copy link
Contributor Author

tekeri commented Nov 11, 2019

OK, how can I fix this package?

@FRidh
Copy link
Member

FRidh commented Nov 11, 2019

Well, aside from introducing tornado 5 compatibility there isn't anything you can do inside python-packages.nix.

@FRidh
Copy link
Member

FRidh commented Nov 11, 2019

If it is used only as an application, then it could be moved out of python-packages.nix and python-modules/ and use tornado_4.

@tekeri
Copy link
Contributor Author

tekeri commented Nov 11, 2019

It seems the upstream is not willing to introduce tornado 5 compatibility... ( circus-tent/circus#1064 )
As it is an application, moving it out of python packages set should be the way to go.
Thanks!

FRidh
FRidh reviewed Nov 11, 2019
View reviewed changes
pkgs/tools/networking/circus/default.nix
@@ -1,7 +1,7 @@
{ stdenv, buildPythonPackage, fetchPypi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass in python3 instead of the python packages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to fix

Copy link
Contributor Author

@tekeri tekeri Nov 11, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean add python3Packages to args and use referrence to python3Packages.buildPythonPackage?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe done

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@FRidh FRidh merged commit cd41194 into NixOS:master Nov 11, 2019
@tekeri
Copy link
Contributor Author

tekeri commented Nov 12, 2019

Thanks @FRidh

@tekeri tekeri deleted the fix-python-circus-imcompat-tornade branch November 12, 2019 11:07
@natsukium natsukium mentioned this pull request Jul 12, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tekeri @FRidh