Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.LogDispatchFileRotate: init at 1.36 #73200

Merged
merged 1 commit into from Nov 11, 2019

Conversation

tekeri
Copy link
Contributor

@tekeri tekeri commented Nov 11, 2019

Motivation for this change

Add a missing perl package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @c0bw3b @7c6f434c @puckipedia

@tekeri tekeri changed the title perlPackages-Log-Dispatch-FileRotate-1.36: init at 1.36 perlPackages-Log-Dispatch-FileRotate: init at 1.36 Nov 11, 2019
@tekeri tekeri changed the title perlPackages-Log-Dispatch-FileRotate: init at 1.36 perlPackages.Log-Dispatch-FileRotate: init at 1.36 Nov 11, 2019
@tekeri tekeri changed the title perlPackages.Log-Dispatch-FileRotate: init at 1.36 perlPackages.LogDispatchFileRotate: init at 1.36 Nov 11, 2019
@tekeri tekeri force-pushed the add-perl-logdispatchfilerotate branch from c8e5958 to a4b4681 Compare November 11, 2019 11:55
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

2 package were build:
perl528Packages.LogDispatchFileRotate perl530Packages.LogDispatchFileRotate

@7c6f434c 7c6f434c merged commit e944d42 into NixOS:master Nov 11, 2019
@tekeri
Copy link
Contributor Author

tekeri commented Nov 12, 2019

Thanks for reviewing multiple PRs @stigtsp, @7c6f434c

@tekeri tekeri deleted the add-perl-logdispatchfilerotate branch November 12, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants