New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nginx perl modules #73198
Add nginx perl modules #73198
Conversation
Was Perl in the runtime closure before? |
@7c6f434c No, it is new dependency. |
Then maybe create a way (like overriding |
91b696d
to
5b71f18
Compare
5b71f18
to
83cfa57
Compare
Right, got it. |
I would prefer opt-in unless a specific feature/set of features implemented as Perl modules and planned for packaging sound useful enough. |
I understand :) |
I am not sure if there is a cheap example of a perl module to add as a NixOS test for Nginx or not. (Or maybe it is a part of your larger Perl strategy and I will see it in a week…) |
I don't have some perl module suitable for NixOS test since perl_module support is just needed for my private module (single file)... FYI the following code can be used to run a perl module.
|
Maybe add |
@7c6f434c Could you check new commit? |
@7c6f434c Thanks! |
* nginx: enable perl_module if perl is given * nginx: move `perl = null` to toplevel (cherry picked from commit a5f2664)
Motivation for this change
Allows Nginx to have perl modules.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @thoughtpolice @7c6f434c @fpletz @globin