Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.LogJournald: init at 0.30 #73279

Merged
merged 1 commit into from Nov 13, 2019
Merged

perlPackages.LogJournald: init at 0.30 #73279

merged 1 commit into from Nov 13, 2019

Conversation

tekeri
Copy link
Contributor

@tekeri tekeri commented Nov 12, 2019 •
edited

Motivation for this change

Add a missing perl module. It also provides a patch to fix build with newer systemd.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @stigtsp @7c6f434c

@tekeri tekeri changed the title perlPackages.LogJournald: init at 0.30 WIP: perlPackages.LogJournald: init at 0.30 Nov 12, 2019
@tekeri tekeri changed the title WIP: perlPackages.LogJournald: init at 0.30 perlPackages.LogJournald: init at 0.30 Nov 12, 2019
@tekeri
Copy link
Contributor Author

tekeri commented Nov 12, 2019

This module is in use with private module.

jonringer
jonringer reviewed Nov 13, 2019
View reviewed changes
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
@tekeri tekeri force-pushed the add-perl-logjournald branch 2 times, most recently from 94bca19 to 2209482 Compare November 13, 2019 09:33
jonringer
jonringer approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (but i dont usually deal with perl)

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73279
2 package were build:
perl528Packages.LogJournald perl530Packages.LogJournald

@7c6f434c 7c6f434c merged commit bc14075 into NixOS:master Nov 13, 2019
@tekeri tekeri deleted the add-perl-logjournald branch November 14, 2019 05:19
@tekeri
Copy link
Contributor Author

tekeri commented Nov 14, 2019

Thanks @jonringer, @7c6f434c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tekeri @jonringer @7c6f434c