Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix grafana smtp enable typo #73280

Merged
merged 1 commit into from Nov 14, 2019
Merged

fix grafana smtp enable typo #73280

merged 1 commit into from Nov 14, 2019

Conversation

PsyanticY
Copy link
Contributor

Can we port it back to 19.09 ?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 13, 2019
@jonringer
Copy link
Contributor

do you have a good way to demonstrate that this fixes the behavior of the module?

@PsyanticY
Copy link
Contributor Author

well the docs says it should be "enabled": https://grafana.com/docs/installation/configuration/#smtp. I have some nix expression to deploy a grafana dashboard i can share.

@jonringer
Copy link
Contributor

do you mind changing the commit message and PR title to:

nixos/grafana: fix smtp enable typo

@PsyanticY
Copy link
Contributor Author

@jonringer done

@jonringer
Copy link
Contributor

requested a review from people who did more than trivial changes to the file

lopsided98
lopsided98 approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@lopsided98 lopsided98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use SMTP with Grafana, but based on the documentation, this looks correct.

See https://grafana.com/docs/installation/configuration/#using-environment-variables for how the options are mapped to environment variables.

@Mic92 Mic92 merged commit 7fa1927 into NixOS:master Nov 14, 2019
@Mic92
Copy link
Member

Mic92 commented Nov 14, 2019

backport: 791e387

@jonringer jonringer added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopsided98 lopsided98 lopsided98 approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@ocharles ocharles Awaiting requested review from ocharles

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PsyanticY @jonringer @Mic92 @lopsided98