Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbis-open: init at 9.1.0 #73282

Merged
merged 1 commit into from Nov 27, 2019
Merged

pbis-open: init at 9.1.0 #73282

merged 1 commit into from Nov 27, 2019

Conversation

tekeri
Copy link
Contributor

@tekeri tekeri commented Nov 12, 2019

Motivation for this change

For Active Directory integration. This PR only contains the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dtzWill @abbradar @vcunat @edolstra
(members are chosen from linux-pam committers)

@tekeri tekeri force-pushed the add-open-pbis branch 2 times, most recently from e120b02 to c759b7e Compare November 13, 2019 10:12
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to test this? :)

pkgs/tools/security/pbis/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

otherwise LGTM

@tekeri
Copy link
Contributor Author

tekeri commented Nov 14, 2019

lwsmd is main daemon. It would start without link error but provide nothing yet.
Next PR come with the systemd service with initialization script and NixOS options that unlock its features. It works well with production AD.
To test its functionality, you need a working Windows server, though.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (I can't think a better way, other than small additions)
executables seem to work
.so's all seem to be linked correctly

[3 built, 4 copied (8.0 MiB), 1.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73282
1 package were build:
pbis-open
[nix-shell:/home/jon/.cache/nix-review/pr-73282]$ nix path-info -Sh ./results/pbis-open
/nix/store/8hh11xi3y4xs0m7v2zcv0i5dickw060a-pbis-open-9.1.0      184.1M

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pbis-open

@tekeri
Copy link
Contributor Author

tekeri commented Nov 15, 2019

it seems this depends on gencat binary provided by glibc.
build is okay out of Nix because macOS has native /usr/bin/gencat.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pbis-open

@Lassulus
Copy link
Member

seems to fail on darwin because it can't find gencat? maybe some if is required?


nativeBuildInputs = [
autoconf automake libtool perl flex bison
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fix darwin build

Suggested change
];
]
# needs gencat
++ stdenv.lib.optionals stdenv.isDarwin [ glibc ];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glibc has meta.platform = lib.platforms.linux;. I tried to add darwin to it and to build with withLinuxHeaders = false;, but it failed for some reason...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I'm sure there's a way to get gencat available, I'm just not sure how

@tekeri
Copy link
Contributor Author

tekeri commented Nov 27, 2019

reduced the number of platforms to move forward

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pbis-open

@jonringer jonringer merged commit d35bd2f into NixOS:master Nov 27, 2019
@tekeri
Copy link
Contributor Author

tekeri commented Nov 28, 2019

@jonringer Thanks!

@tekeri tekeri deleted the add-open-pbis branch November 28, 2019 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants