New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pbis-open: init at 9.1.0 #73282
pbis-open: init at 9.1.0 #73282
Conversation
e120b02
to
c759b7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to test this? :)
otherwise LGTM |
|
c759b7e
to
216fb69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM (I can't think a better way, other than small additions)
executables seem to work
.so's all seem to be linked correctly
[3 built, 4 copied (8.0 MiB), 1.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73282
1 package were build:
pbis-open
[nix-shell:/home/jon/.cache/nix-review/pr-73282]$ nix path-info -Sh ./results/pbis-open
/nix/store/8hh11xi3y4xs0m7v2zcv0i5dickw060a-pbis-open-9.1.0 184.1M
@GrahamcOfBorg build pbis-open |
216fb69
to
8ad4c7c
Compare
it seems this depends on |
@GrahamcOfBorg build pbis-open |
seems to fail on darwin because it can't find gencat? maybe some if is required? |
|
||
nativeBuildInputs = [ | ||
autoconf automake libtool perl flex bison | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to fix darwin build
]; | |
] | |
# needs gencat | |
++ stdenv.lib.optionals stdenv.isDarwin [ glibc ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glibc
has meta.platform = lib.platforms.linux;
. I tried to add darwin to it and to build with withLinuxHeaders = false;
, but it failed for some reason...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I'm sure there's a way to get gencat available, I'm just not sure how
8ad4c7c
to
afebf1e
Compare
reduced the number of platforms to move forward |
@GrahamcOfBorg build pbis-open |
@jonringer Thanks! |
Motivation for this change
For Active Directory integration. This PR only contains the package.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @dtzWill @abbradar @vcunat @edolstra
(members are chosen from linux-pam committers)