Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiles/graphical.nix: Drop systemWide pulseaudio in iso #73232

Merged
merged 1 commit into from Nov 12, 2019
Merged

profiles/graphical.nix: Drop systemWide pulseaudio in iso #73232

merged 1 commit into from Nov 12, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Nov 11, 2019

Motivation for this change

It's not needed since #66338 and should have been done earlier.

This is based on a follow-up on #56167.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@etu
profiles/graphical.nix: Drop systemWide pulseaudio in iso
4403cd1 
It's not needed since NixOS#66338 and should have been done earlier.

This is based on a follow-up on NixOS#56167.
@worldofpeace
Copy link
Contributor

Did the users of graphical.nix ever use a root user?
It appears Demo user account is what's used in demo.nix, so I'm not sure this was ever needed.

worldofpeace
worldofpeace approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no testing done but I believe it was unneeded anyway. We could probably backport it even.

@etu
Copy link
Contributor Author

etu commented Nov 12, 2019

@worldofpeace

Did the users of graphical.nix ever use a root user?

Yes it did. That's why I added that line. I tested it myself both before and after adding the line on actual hardware.

It appears Demo user account is what's used in demo.nix, so I'm not sure this was ever needed.

I'm not sure what demo.nix is for...

@etu etu requested a review from adisbladis November 12, 2019 06:49
@worldofpeace
Copy link
Contributor

@etu I believe it's for the ova. We have this annoying inconsistency with the ISO's and the OVA.
Even worse is we've documented and exposed them https://nixos.org/nixos/manual/index.html#sec-profile-demo, https://nixos.org/nixos/manual/index.html#sec-profile-graphical. I really hope no one was using this.

@adisbladis adisbladis merged commit cc56226 into NixOS:master Nov 12, 2019
@etu etu deleted the disable-systemwide-pulse-iso branch November 12, 2019 12:45
@worldofpeace
Copy link
Contributor

#66338 is in 19.09 so I think we should backport this.

@etu
Copy link
Contributor Author

etu commented Nov 12, 2019

@worldofpeace Yeah, we should. I'll look into it later today unless someone does it before me.

@etu etu mentioned this pull request Nov 13, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @worldofpeace @adisbladis