Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc: Deduplicate preConfigure and configureFlags #73181

Merged
merged 2 commits into from Nov 10, 2019
Merged

gcc: Deduplicate preConfigure and configureFlags #73181

merged 2 commits into from Nov 10, 2019

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport of #73180

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ericson2314
gcc: Deduplicate preConfigure
f666c61
@Ericson2314
gcc: Deduplicate configureFlags
5c5ca01 
Thanks again to @bgamari who in 1c12072
did the cleanup to make this possible. It's been a long time coming!
@Ericson2314 Ericson2314 merged commit fecedd4 into NixOS:release-19.09 Nov 10, 2019
@Ericson2314 Ericson2314 deleted the gcc-dedup-configure-flags-19.09 branch November 10, 2019 21:45
@ivan ivan mentioned this pull request Nov 12, 2019
Closed
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 12, 2019

Was it necessary to backport this?

@Ericson2314
Copy link
Member Author

It was because the MinGW change I also backported depends on it. I need that in turn for NixOS/nix#3185, since Nix is CI'd against stable nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer matthewbauer is a code owner

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @c0bw3b