Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC 6: Fix java support #73291

Merged
merged 1 commit into from Nov 12, 2019
Merged

GCC 6: Fix java support #73291

merged 1 commit into from Nov 12, 2019

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Nov 12, 2019 •
edited

Motivation for this change

Major version upper bound was one too low. Sorry!

FIxes #73271

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ericson2314
GCC 6: Fix java support
903bdf1 
Major version upper bound was one too low.
@Ericson2314 Ericson2314 mentioned this pull request Nov 12, 2019
Merged
10 tasks
@Ericson2314
Copy link
Member Author

Ericson2314 commented Nov 12, 2019 •
edited

@ofborg build gcj

@matthewbauer matthewbauer merged commit 93fd7d8 into NixOS:master Nov 12, 2019
@Ericson2314 Ericson2314 deleted the fix-gcj branch November 12, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[19.09] cannot eval gcj, gcj-wrapper
2 participants
@Ericson2314 @matthewbauer