Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.authlib: init at 0.13 #73290

Merged
merged 1 commit into from Nov 14, 2019
Merged

python3.pkgs.authlib: init at 0.13 #73290

merged 1 commit into from Nov 14, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 12, 2019

Motivation for this change

This adds authlib, a popular OAuth and OpenID Connect library.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested review from zimbatm and FRidh November 12, 2019 14:56
@flokli flokli force-pushed the authlib-0.13 branch 2 times, most recently from d12fbcd to 7c52534 Compare November 13, 2019 23:44
@flokli @jonringer
python3.pkgs.authlib: init at 0.13
ed691f9 
Co-authored-by: Jonathan Ringer <jonringer117@gmail.com>
jonringer
jonringer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[5 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73290
3 package were build:
python27Packages.authlib python37Packages.authlib python38Packages.authlib

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.authlib python37Packages.authlib python38Packages.authlib

@jonringer jonringer merged commit b64034e into NixOS:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @jonringer